Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#162207] Add a message to cross-core statements #4324

Merged
merged 12 commits into from
Jun 12, 2024
Merged

[#162207] Add a message to cross-core statements #4324

merged 12 commits into from
Jun 12, 2024

Conversation

giladshanan
Copy link
Collaborator

@giladshanan giladshanan commented Jun 7, 2024 •
edited
Loading

Release Notes

Adds a message to cross-core statements which include cross-core transactions from other facilities.
If the user placed the order, then this message would just cause confusion:
Items on this statement may have been placed on your behalf by another core facility.

This will need to be applied to each school's statement format individually

Screenshot

Screenshot 2024-06-07 at 2 37 52 PM

Tasks

  • Should this be applied to all cross core statements? NO - just the ones that were ordered on behalf
  • Consider using the new cross_core scope in other places, if appropriate
  • Add specs

@giladshanan
Only show the message when there are cross core transactions from ano…
4d23923 
…ther facility

If the user placed the order at Facility A, this message:
Items on this statement may have been placed on your behalf by another core facility.

... will just cause confusion.
@giladshanan
Refactor cross_core scope on OrderDetail
813a721
@giladshanan
Make scope more readable
f22a7c6
@giladshanan
Add facilities table back into the cross_core scope
4d6b75b
@giladshanan giladshanan marked this pull request as ready for review June 10, 2024 19:10
@giladshanan giladshanan requested a review from a team as a code owner June 10, 2024 19:10
LeticiaErrandonea
LeticiaErrandonea approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@LeticiaErrandonea LeticiaErrandonea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor in the specs!

app/support/example_statement_pdf.rb Outdated Show resolved Hide resolved
spec/support/contexts/cross_core_context.rb Outdated Show resolved Hide resolved
@giladshanan giladshanan merged commit 4085e36 into master Jun 12, 2024
3 checks passed
@giladshanan giladshanan deleted the 162207-cross-core-message-in-statements branch June 12, 2024 14:33
@giladshanan giladshanan changed the title [#162207] Add a message to all cross-core statements [#162207] Add a message to cross-core statements Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeticiaErrandonea LeticiaErrandonea LeticiaErrandonea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giladshanan @LeticiaErrandonea