Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Windows 11 information #242

Merged
merged 2 commits into from
Nov 1, 2023
Merged

fix: Windows 11 information #242

merged 2 commits into from
Nov 1, 2023

Conversation

idranme
Copy link
Contributor

@idranme idranme commented Oct 31, 2023

fixes #209

Currently, Windows 11 systems are recognized as Windows 10, this PR will fix that.

@gengjiawen
Copy link
Collaborator

What's sample output on windows 11 now ?

@idranme
Copy link
Contributor Author

idranme commented Nov 1, 2023

Before modification:

System:
    OS: Windows 10 10.0.22621
    CPU: (8) x64 Intel(R) Core(TM) i3-10105F CPU @ 3.70GHz
    Memory: 5.61 GB / 15.90 GB
  Binaries:
    Node: 20.9.0 - ~\AppData\Local\Temp\xfs-56dd4235\node.CMD
    Yarn: 3.5.1 - ~\AppData\Local\Temp\xfs-56dd4235\yarn.CMD
    npm: 10.1.0 - C:\Program Files\nodejs\npm.CMD
  Managers:
    Cargo: 1.71.1 - ~\.cargo\bin\cargo.EXE
    pip3: 23.3 - ~\AppData\Local\Programs\Python\Python311\Scripts\pip3.EXE
  Utilities:
    CMake: 3.27.3 - C:\Program Files\CMake\bin\cmake.EXE
    Git: 2.42.0. - C:\Program Files\Git\cmd\git.EXE
    Clang: 17.0.2 - C:\Program Files\LLVM\bin\clang.EXE
    Ninja: 1.11.1 - C:\Users\28648\scoop\shims\ninja.EXE
    FFmpeg: 6.0 - C:\Users\28648\Downloads\ffmpeg-6.0-full_build\ffmpeg-6.0-full_build\bin\ffmpeg.EXE
    Curl: 8.0.1 - C:\Windows\system32\curl.EXE
  Virtualization:
    Docker: 24.0.5 - C:\Program Files\Docker\Docker\resources\bin\docker.EXE
  IDEs:
    VSCode: 1.83.1 - C:\Users\28648\AppData\Local\Programs\Microsoft VS Code\bin\code.CMD
    Visual Studio: 17.6.33829.357 (Visual Studio Community 2022)
  Languages:
    Go: 1.21.0 - C:\Users\28648\scoop\shims\go.EXE
    Java: 17.0.8 - C:\Program Files\Microsoft\jdk-17.0.8.7-hotspot\bin\javac.EXE
    Python: 3.11.4 - C:\Users\28648\AppData\Local\Programs\Python\Python311\python.EXE
    Rust: 1.71.1 - C:\Users\28648\.cargo\bin\rustc.EXE
  Browsers:
    Edge: Chromium (118.0.2088.76)
    Internet Explorer: 11.0.22621.1

After modification:

System:
    OS: Windows 11 10.0.22621
    CPU: (8) x64 Intel(R) Core(TM) i3-10105F CPU @ 3.70GHz
    Memory: 5.43 GB / 15.90 GB
  Binaries:
    Node: 20.9.0 - ~\AppData\Local\Temp\xfs-d9a08d75\node.CMD
    Yarn: 3.5.1 - ~\AppData\Local\Temp\xfs-d9a08d75\yarn.CMD
    npm: 10.1.0 - C:\Program Files\nodejs\npm.CMD
  Managers:
    Cargo: 1.71.1 - ~\.cargo\bin\cargo.EXE
    pip3: 23.3 - ~\AppData\Local\Programs\Python\Python311\Scripts\pip3.EXE
  Utilities:
    CMake: 3.27.3 - C:\Program Files\CMake\bin\cmake.EXE
    Git: 2.42.0. - C:\Program Files\Git\cmd\git.EXE
    Clang: 17.0.2 - C:\Program Files\LLVM\bin\clang.EXE
    Ninja: 1.11.1 - C:\Users\28648\scoop\shims\ninja.EXE
    FFmpeg: 6.0 - C:\Users\28648\Downloads\ffmpeg-6.0-full_build\ffmpeg-6.0-full_build\bin\ffmpeg.EXE
    Curl: 8.0.1 - C:\Windows\system32\curl.EXE
  Virtualization:
    Docker: 24.0.5 - C:\Program Files\Docker\Docker\resources\bin\docker.EXE
  IDEs:
    VSCode: 1.83.1 - C:\Users\28648\AppData\Local\Programs\Microsoft VS Code\bin\code.CMD
    Visual Studio: 17.6.33829.357 (Visual Studio Community 2022)
  Languages:
    Go: 1.21.0 - C:\Users\28648\scoop\shims\go.EXE
    Java: 17.0.8 - C:\Program Files\Microsoft\jdk-17.0.8.7-hotspot\bin\javac.EXE
    Python: 3.11.4 - C:\Users\28648\AppData\Local\Programs\Python\Python311\python.EXE
    Rust: 1.71.1 - C:\Users\28648\.cargo\bin\rustc.EXE
  Browsers:
    Edge: Chromium (118.0.2088.76)
    Internet Explorer: 11.0.22621.1

@gengjiawen gengjiawen merged commit 5330fb2 into tabrindle:main Nov 1, 2023
8 checks passed
@gengjiawen
Copy link
Collaborator

Thx for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Version of Windows
2 participants