[WIP] Add fish completions (Fixing #118)

[harmtemolder]

I dove into the way fish completions work and came up with a solution to add them for pass otp. They work, but still a couple of TODOs before it's ready for production:

• Do not suggest a second subcommand after a first one is used
• Do not suggest --clip on insert, append or validate
• Do not hard-code the path to the main pass completions
• Make sure the Makefile does not overwrite the main pass completions
• Make sure the default FISHCOMPDIR is in $fish_complete_path, and before the main pass completions' location

[pickfire]

I think it should be called pass-otp since it might interfere with pass?

[harmtemolder]

I actually tried that first, but it seemed like fish uses the filename to apply its completions to a specific command (in this case pass). If you know of a way to name this file pass-otp.fish I'm all for it

[pickfire]

But won't that overwrite the default pass.fish?

[harmtemolder]

Yes, that's why by default this pass.fish installs into /etc/fish/completions and reads the default pass.fish from /usr/share/fish/vendor_completions.d/pass.fish. That is where the default ones are on my system, but I can't guarantee that on other systems. That's why checkboxes 3 and 4 are still open

[tadfisher]

Yeah, the setup for completions is kind of messy and I haven't looked at this for a while. Lemme check upstream and get back to you.

[tadfisher]

So, the ideal solution would be for pass to delegate to extension completion scripts itself, similar to what it does for pass git and pass grep here: https://git.zx2c4.com/password-store/commit/?id=06f499994071bb6131244218b25d637103afe1d5. This should be a reasonable change to submit upstream.

[apastuszak]

If you installed pass on a Mac using homebrew the path to the completion file is:

/opt/homebrew/share/fish/vendor_completions.d/pass.fish

Shouldn't the path be set by the package maintainer for whatever distro this is packaged for?

This is working great on my Mac.

[harmtemolder]

This is working great on my Mac.

Do you mean these added completions?

Shouldn't the path be set by the package maintainer for whatever distro this is packaged for?

I guess it should, but I'm not in the trade of making packages and don't know how to do this. That means I'd need help to finish this PR.

@tadfisher Can you—or do you know anyone who can—help me figure out a way to dynamically get the location of the original pass's completions so that I don't have to hard-code them?

[vonpupp]

I made my own completion following @tadfisher's comments. These are on a separate file named 'pass-otp.fish' and instead of copying it to /usr/share/fish/vendor_completions.d/pass.fish, I copy to my private XDG config file (.config/fish/completions/), so it doesn't conflict with pass.fish. I know nothing about fish completions, I basically copied and pasted and followed along the pass git command as suggested, but it seems to be working fine.

Personally I manage that file within my dotfiles, but if you want I can open a PR to contribute this file. I am not sure how to add that to the Makefile but it shouldn't be that hard.

[BarbzYHOOL]

I made my own completion following @tadfisher's comments. These are on a separate file named 'pass-otp.fish' and instead of copying it to /usr/share/fish/vendor_completions.d/pass.fish, I copy to my private XDG config file (.config/fish/completions/), so it doesn't conflict with pass.fish. I know nothing about fish completions, I basically copied and pasted and followed along the pass git command as suggested, but it seems to be working fine.

Personally I manage that file within my dotfiles, but if you want I can open a PR to contribute this file. I am not sure how to add that to the Makefile but it shouldn't be that hard.

i tried this but it doesn't help one bit with this issue at least #187

[pickfire]

I guess this should be closed since it's superseeded by another PR?