Improvement of NSManagedObject.firstOrCreate

[anirudhamahale]

I would like to give one suggestion regarding the firstOrCreate function.
while doing firstOrCreate keep one primary key so that you can check if that key already exists then only update the data related to that key instead of creating one more record.

to demonstrate suppose say I have an NSManagedObject called Person which keeps his id, balance, name, phone, email as String. So each time I call the update_person_record gives me an array of id, balance, name, phone, email.

So upon calling this
let value = ["id":id, "balance" : balance, "name": name, "phone": phone, "email": email]; _ = Person.firstOrCreate(with: value); AERecord.save();

It will create the same person with same details having a different balance. So please provide a primary key so that it will directly update values which have been updated.

[tadija]

Hi @anirudhamahale,

I suggest you just do it like this:

// get person by id if it already exists, otherwise create new
let person = Person.firstOrCreate(with: ["id" : id]) 
// update data on either existing or a new person
person.name = name
person.email = email
person.phone = phone
person.balance = balance

Cheers,
// T