Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "public" for methods and constructors. #10

Closed
hohl opened this issue Dec 12, 2014 · 1 comment
Closed

Use "public" for methods and constructors. #10

hohl opened this issue Dec 12, 2014 · 1 comment

Comments

@hohl
Copy link

hohl commented Dec 12, 2014

Nearly all methods (including subscriptions and constructors) are not public. Without declaring them as public it is impossible to use that class when using it within an framework.
tadija added a commit that referenced this issue Dec 12, 2014
@tadija
Added a few computed properties to AEXMLElement
01546fd 
Improved access control so it can be used within a framework (issue #10)
Update README.md
@tadija
Copy link
Owner

tadija commented Dec 12, 2014

Hello, this is fixed now. Thanks for mentioning that.

@tadija tadija closed this as completed Dec 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hohl @tadija