New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define controllers as services #20

Closed

taemin19 opened this issue Jan 9, 2019 · 0 comments

Owner

taemin19 commented Jan 9, 2019 •

edited

Loading

Define controllers as services and don't extend them to a base controller class :

to inject directly the dependencies via a normal constructor dependency injection or "action" injection in controllers
to avoid fetching public services via $this->get()
to decrease runtime performance impact

This was referenced Jan 9, 2019

Add unit tests for controllers #19

Closed

Refactor controllers to use dependency injection #21

Merged

taemin19 closed this as completed in

0004e8f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment