-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to tokio 1.0 #18
Conversation
👍 |
Hey folks, Just giving a heads up that these dependencies were updated to use tokio 1.0:
|
Thanks for the update Felipe. There are no longer any git dependencies. The PR is ready to be merged. |
It seems like I made the changes in a branch on my fork, if you think that it is a good idea, feel free to add the commit to your PR. |
I just found out, that clippy isn't fond of wildcard dependencies (and rightly so ;) ). So I changed the |
@@ -2,19 +2,20 @@ | |||
//! | |||
//! # Example | |||
//! ```rust,no_run | |||
//! use hyper::{Client, Request, Uri}; | |||
//! use hyper::{Client, Request, Uri, body::HttpBody}; | |||
//! use hyper::client::HttpConnector; | |||
//! use futures::{TryFutureExt, TryStreamExt}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These types are no longer required. Also, the README.md example should be updated.
The hyper-openssl support is added as a new feature to hyper-proxy. It is used to perform crypto operations using keypairs via OpenSSL engine. This commit also adds support for Tokio 1.0 (adapted from tafia/hyper-proxy#18), needed to interoperate with native-tls and hyper crates that are already upgraded to Tokio 1.0.
@tafia can you please merge and publish to crates.io? |
Sorry for that! |
Thank you, much appreciated! |
This should not yet be merged as some dependencies have not yet had a new release with tokio 1.0 support as seen by git dependencies.Ready to merge.
I changed the doc example in lib.rs to the hyper example https://github.com/hyperium/hyper/blob/master/examples/client.rs because I got annoyed at finding the right combinators.