Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to tokio 1.0 #454

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Upgrade to tokio 1.0 #454

merged 1 commit into from
Mar 25, 2021

Conversation

e00E
Copy link
Contributor

@e00E e00E commented Jan 22, 2021

Closes #445

This should not be merged yet because there are two git dependencies. For both crates I have created PRs to update them to tokio 1.0 but they have not been merged yet:

@e00E e00E force-pushed the tokio-1.0 branch 4 times, most recently from 88b32b3 to 78a134e Compare January 22, 2021 14:21
@tomusdrw
Copy link
Owner

tomusdrw commented Feb 3, 2021

Awesome!

@wesrer
Copy link

wesrer commented Feb 26, 2021

Both these libraries have updated to tokio 1.0 as of today, I believe. @tomusdrw @e00E is this ready to be merged yet?

@e00E
Copy link
Contributor Author

e00E commented Feb 26, 2021

They have merged the PR but haven't had a release to crates.io yet so we still have to wait:

@toxeus
Copy link
Contributor

toxeus commented Mar 3, 2021

✔️ hyper-proxy had a new release recently
async-native-tls is still pending

@tomusdrw
Copy link
Owner

@e00E do you mind rebasing the PR? I'm considering merging this even with async-native-tls being a git dependency for now.

@e00E
Copy link
Contributor Author

e00E commented Mar 25, 2021

Done. Btw you won't be able to make a crates.io release with a git dependency.

Copy link
Owner

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomusdrw tomusdrw merged commit 47b4f04 into tomusdrw:master Mar 25, 2021
@tomusdrw tomusdrw mentioned this pull request Mar 25, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tokio to 1.0
4 participants