Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified dictionary-based tag interface #23

Merged
merged 44 commits into from
Mar 17, 2012
Merged

Unified dictionary-based tag interface #23

merged 44 commits into from
Mar 17, 2012

Commits on Aug 26, 2011

  1. Some preliminary work for unified dictionary tag interface support. 

    - toDict() and fromDict() for XiphComments
- toDict() for ID3v2 Tags
    Michael Helmling committed Aug 26, 2011
    Configuration menu
    Copy the full SHA
    b262180 View commit details
    Browse the repository at this point in the history

  2. More support for the unified dictionary interface. 

    Addded fromDict() function to ID3v2Tag. Added fromDict() and
toDict() functions to the TagUnion class (uses the first non-empty tag).
Added fromDict() and toDict() functions for the generic Tag class, only
handling common tags without duplicates. Addded preliminary mp3 test
case. Python3 bindings now available on my github site.
    Michael Helmling committed Aug 26, 2011
    Configuration menu
    Copy the full SHA
    58db919 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2011

  1. Added toDict and fromDict methods for APE tags.

    Michael Helmling committed Aug 27, 2011
    Configuration menu
    Copy the full SHA
    fa8159a View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2011

  1. Made im/export functions nonvirtual. Added similar functions to File and 

    its subclasses. TagLib::File contains a bunch of dynamic_casts to call
the correct specializations.
    Michael Helmling committed Aug 28, 2011
    Configuration menu
    Copy the full SHA
    5647b2e View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2011

  1. Merge remote-tracking branch 'official/master'

    Michael Helmling committed Sep 1, 2011
    Configuration menu
    Copy the full SHA
    0356249 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2011

  1. Splitted ID3v2Tag::toDict() into several functions. 

    This should simplify future transition to virtual functions.
    Michael Helmling committed Sep 11, 2011
    Configuration menu
    Copy the full SHA
    2d31075 View commit details
    Browse the repository at this point in the history

  2. Restructured and simplified ID3v2Tag::fromDict().

    Michael Helmling committed Sep 11, 2011
    Configuration menu
    Copy the full SHA
    0c2ca20 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2011

  1. Further cleanup and simplification in id3v2dicttools

    Michael Helmling committed Sep 12, 2011
    Configuration menu
    Copy the full SHA
    772bc9f View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2011

  1. Merge remote-tracking branch 'official/master'

    Michael Helmling committed Oct 30, 2011
    Configuration menu
    Copy the full SHA
    292a377 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2011

  1. Implemented dict interface for more formats. 

    Now supported: MOD files (IT, MOD, S3M, XM), RIFF files
(AIFF, WAV), TrueAudio, WavPack.
    Michael Helmling committed Nov 2, 2011
    Configuration menu
    Copy the full SHA
    0eaf3a3 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2012

  1. Added tests and information about ignored id3 frames. 

    The ID3v2::toDict() function now has an optional
StringList* argument which will contain information
about frames that could not be converted to the dict
interface.
There are some dict tests for APE and FLAC now, and the
ID3v2 test was enlarged.
    Michael Helmling committed Jan 1, 2012
    Configuration menu
    Copy the full SHA
    c4cef55 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2012

  1. Merge remote-tracking branch 'official/master'

    Michael Helmling committed Jan 4, 2012
    Configuration menu
    Copy the full SHA
    7875d02 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2012

  1. Merge remote-tracking branch 'official/master'

    Michael Helmling committed Jan 14, 2012
    Configuration menu
    Copy the full SHA
    ea41cd8 View commit details
    Browse the repository at this point in the history

  2. Implemented the most easy comments on the pull request.

    Michael Helmling committed Jan 14, 2012
    Configuration menu
    Copy the full SHA
    67d896e View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2012

  1. Basic implementation of a PropertyMap. 

    Implemented key/valuelist property map with
case-insensitive ASCII keys and StringList values.

Todo:
- subclass StringList to add flags indicating whether a value could
be written to the specific file format
- add member attribute indicating list of frames that could not be
parsed into the PropertyMap representation.
    Michael Helmling committed Jan 16, 2012
    Configuration menu
    Copy the full SHA
    d11189b View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2012

  1. Add unsupportedData() to PropertyMap, simplified [] behavior.

    Michael Helmling committed Jan 17, 2012
    Configuration menu
    Copy the full SHA
    18ae797 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2012

  1. Migration to new PropertyMap ... done ape to mod.

    Michael Helmling committed Jan 21, 2012
    Configuration menu
    Copy the full SHA
    e4d955d View commit details
    Browse the repository at this point in the history

  2. Started to work on ID3v2.

    Michael Helmling committed Jan 21, 2012
    Configuration menu
    Copy the full SHA
    a5e45f1 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2012

  1. Implemented asProperties() in all relevant textual frames.

    Michael Helmling committed Jan 22, 2012
    Configuration menu
    Copy the full SHA
    0c8e5bb View commit details
    Browse the repository at this point in the history

  2. More progress in ID3 ... setProperties() will get messy :(

    Michael Helmling committed Jan 22, 2012
    Configuration menu
    Copy the full SHA
    a8632f7 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2012

  1. ID3 interface complete; vorbis done; wav done

    Michael Helmling committed Feb 14, 2012
    Configuration menu
    Copy the full SHA
    d2c43d7 View commit details
    Browse the repository at this point in the history

  2. Ported s3m; removed old id3v2dicttools.

    Michael Helmling committed Feb 14, 2012
    Configuration menu
    Copy the full SHA
    48aaaf8 View commit details
    Browse the repository at this point in the history

  3. Ported trueaudio.

    Michael Helmling committed Feb 14, 2012
    Configuration menu
    Copy the full SHA
    2185d52 View commit details
    Browse the repository at this point in the history

  4. Ported wavpack.

    Michael Helmling committed Feb 14, 2012
    Configuration menu
    Copy the full SHA
    d621536 View commit details
    Browse the repository at this point in the history

  5. Ported xm.

    Michael Helmling committed Feb 14, 2012
    Configuration menu
    Copy the full SHA
    8a8e9b7 View commit details
    Browse the repository at this point in the history

  6. fixed lots of bugs found by 'make'

    Michael Helmling committed Feb 14, 2012
    Configuration menu
    Copy the full SHA
    140f4a5 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2012

  1. Added lots of missing includes

    Michael Helmling committed Feb 15, 2012
    Configuration menu
    Copy the full SHA
    de51307 View commit details
    Browse the repository at this point in the history

  2. Fixed id3v2 test

    Michael Helmling committed Feb 15, 2012
    Configuration menu
    Copy the full SHA
    cfa5ac6 View commit details
    Browse the repository at this point in the history

  3. fixed tests

    Michael Helmling committed Feb 15, 2012
    Configuration menu
    Copy the full SHA
    70c3264 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2012

  1. Added some functions, started to fix bugs.

    Michael Helmling committed Feb 19, 2012
    Configuration menu
    Copy the full SHA
    6c054af View commit details
    Browse the repository at this point in the history

  2. fixed bugs preventing tests from running

    Michael Helmling committed Feb 19, 2012
    Configuration menu
    Copy the full SHA
    23d303a View commit details
    Browse the repository at this point in the history

  3. removed debug messages

    Michael Helmling committed Feb 19, 2012
    Configuration menu
    Copy the full SHA
    495a028 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2012

  1. Added another test for ID3v2 PropertyMap interface; fixed various bugs

    Michael Helmling committed Feb 25, 2012
    Configuration menu
    Copy the full SHA
    d28cc83 View commit details
    Browse the repository at this point in the history

  2. added APE tag PropertyMap test

    Michael Helmling committed Feb 25, 2012
    Configuration menu
    Copy the full SHA
    05b5e06 View commit details
    Browse the repository at this point in the history

  3. Moved APE test to correct place; added MOD tag test.

    Michael Helmling committed Feb 25, 2012
    Configuration menu
    Copy the full SHA
    b8d5246 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'official/master'

    Michael Helmling committed Feb 25, 2012
    Configuration menu
    Copy the full SHA
    9fd2202 View commit details
    Browse the repository at this point in the history

  5. some cosmetic changes

    Michael Helmling committed Feb 25, 2012
    Configuration menu
    Copy the full SHA
    79670be View commit details
    Browse the repository at this point in the history

  6. Added ID3v2 PropertyMap interface documentation.

    Michael Helmling committed Feb 25, 2012
    Configuration menu
    Copy the full SHA
    b05c316 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2012

  1. remove Tests/Examples build from CMakeLists

    Michael Helmling committed Feb 26, 2012
    Configuration menu
    Copy the full SHA
    fa0656e View commit details
    Browse the repository at this point in the history

  2. Fix USLT frame creation in Frame::createTextualFrame()

    Michael Helmling committed Feb 26, 2012
    Configuration menu
    Copy the full SHA
    0a3b998 View commit details
    Browse the repository at this point in the history

  3. Fixed identation

    Michael Helmling committed Feb 26, 2012
    Configuration menu
    Copy the full SHA
    37c87e0 View commit details
    Browse the repository at this point in the history

  4. Add support for Unknown TXXX frames.

    Michael Helmling committed Feb 26, 2012
    Configuration menu
    Copy the full SHA
    f859fcf View commit details
    Browse the repository at this point in the history

  5. Removed quodlibet special case handling

    Michael Helmling committed Feb 26, 2012
    Configuration menu
    Copy the full SHA
    6e6d823 View commit details
    Browse the repository at this point in the history

  6. Fixed handling of UnknownFrames in ID3v2. 

    - If an unknown frame with id "XXXX" occurs, an entry
"UNKNOWN/XXXX" is added to unsupportedData().
The removeUnsupportedProperties() method in turn
removes all unknown frames with id "XXXX" if it
encounters a string "UNKNOWN/XXXX" in the given list.

- Implemented findByDescription() to UnsynchronizedLyricsFrame
in order to support removal of lyrics frames with unsupported
keys.

- Adapted id3v2 test case to new QuodLibet policy.
    Michael Helmling committed Feb 26, 2012
    Configuration menu
    Copy the full SHA
    f5a2518 View commit details
    Browse the repository at this point in the history