Use ctest and install examples #37

Merged
merged 3 commits into from Jul 14, 2012

Projects

None yet

2 participants

@kensington
  1. Use ctest instead of a custom target
  2. Install examples if they are built
@lalinsky lalinsky commented on the diff May 15, 2012
examples/CMakeLists.txt
@@ -45,6 +45,12 @@ ADD_EXECUTABLE(strip-id3v1 strip-id3v1.cpp)
TARGET_LINK_LIBRARIES(strip-id3v1 tag )
+INSTALL(TARGETS
@lalinsky
lalinsky May 15, 2012 TagLib member

I don't think these should be installed.

@kensington
kensington May 16, 2012

I note that this would only be called if BUILD_EXAMPLES is enabled.

How do you feel about an INSTALL_EXAMPLES target instead?

@lalinsky
Member

And I have a few questions, I'm using make test to run the tests, but:

  • If a test fails, I don't see which test failed. Is there a way to display the stdout/stderr from the test runner?
  • It seems that make test doesn't depend on the test runner target, so that if I change the tests and run make test, it will not rebuild the sources. Is that expected?
@kensington

Thanks for the review.

The behaviour you have described is either a feature of a bug of ctest, depending on who you talk to. I have updated the pull request to restore the old check target with verbose output, while still making use of ctest.

@lalinsky lalinsky merged commit b5ad68d into taglib:master Jul 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment