Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence ushort ambiguity errors #691

Merged
merged 1 commit into from
Nov 30, 2015

Conversation

FestusHagen
Copy link
Contributor

No description provided.

TsudaKageyu added a commit that referenced this pull request Nov 30, 2015
@TsudaKageyu TsudaKageyu merged commit b4b16fd into taglib:master Nov 30, 2015
@TsudaKageyu
Copy link
Contributor

Thank you for your catch and fix @FestusHagen.

@TsudaKageyu
Copy link
Contributor

Honestly, I'd like to remove such typedefs and use standard integer types in taglib2 branch.

@sbooth
Copy link
Contributor

sbooth commented Nov 30, 2015

I agree with that! Anything we can do to avoid unnecessary duplication is
worthwhile.

On Mon, Nov 30, 2015 at 10:47 AM Tsuda Kageyu notifications@github.com
wrote:

Honestly, I'd like to remove such typedefs and use standard integer types
in taglib2 branch.


Reply to this email directly or view it on GitHub
#691 (comment).

@FestusHagen
Copy link
Contributor Author

I'd like to see it consistent ...

-Enjoy

@FestusHagen FestusHagen deleted the fh1.m_ushortAmbiguities branch November 30, 2015 17:41
@TsudaKageyu
Copy link
Contributor

It looks like the types like ushort are defined in some standard header.
Assuming that, the ambiguity errors may occur in any header. I think we'd better add TagLib:: to all such types in the public headers.

@TsudaKageyu
Copy link
Contributor

Well, I will create another issue to discuss it.

@TsudaKageyu
Copy link
Contributor

I have eliminated all the custom integer types from the source. I hope this kind of issues will never happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants