Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Player::AddToInventory #133

Open
tagniam opened this issue Oct 25, 2020 · 11 comments
Open

Refactor Player::AddToInventory #133

tagniam opened this issue Oct 25, 2020 · 11 comments

Comments

@tagniam
Copy link
Owner

tagniam commented Oct 25, 2020

Current, Player::AddToInventory(vector<int> drops) adds items to the player's inventory by checking drops[0] for the number of arrows to add, drops[1] for bombs, drops[2] for potions, etc.

We'd like to refactor this such that the method takes a vector of std::pair<ITEMTYPE, int>, where the first element in the pair is the type of the item to add and the second element in the pair is the amount to add.

@drrackett
Copy link

I'd like to work on this.

@saurabh786iit
Copy link

Please assign this to me

@SudarshanHV
Copy link

I would like to work on this.
I would like to know whether you have individual struct types for each of these or you want to be preprocessing strings. Either way, it is doable.

@nikitajuneja1
Copy link

please assign this to me.

1 similar comment
@jvishad
Copy link

jvishad commented Oct 26, 2020

please assign this to me.

@verma-shivani
Copy link

please assign this to me

@pallavi-bits
Copy link
Contributor

hi tagniam i can't find build inside Turn folder neither in the repo nor after cloning...please help how to run the game so that i can understand the code in better way and make contributions

@DJ73
Copy link
Contributor

DJ73 commented Oct 28, 2020

@pallavi-bits To run the game, after cloning the repo, follow the build instructions given in the README.md. That will create a build folder in which you'll find Turn.exe

@pallavi-bits
Copy link
Contributor

I did but got this error-"CMake Error: The source directory "/home/pallavi/Turn/build" does not exist.
Specify --help for usage, or press the help button on the CMake GUI."

@tagniam
Copy link
Owner Author

tagniam commented Oct 29, 2020

@pallavi-bits did you get that message after running cmake -S . -B build? if so, try updating your version of cmake?

@pallavi-bits
Copy link
Contributor

Thanks @tagniam yes the issue was of outdated cmake..now its working good thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants