Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code does not follow Presto HTTP Best Practices #3

Open
thedillonb opened this issue May 12, 2016 · 1 comment
Open

Code does not follow Presto HTTP Best Practices #3

thedillonb opened this issue May 12, 2016 · 1 comment

Comments

@thedillonb
Copy link

Your code doesn't look like it follows what the Presto owners have dictated as the best way to interact with it via HTTP:

https://github.com/prestodb/presto/wiki/HTTP-Protocol

For example, you should not be checking the status field to find out if you need to wait longer for a query. As the Presto owners suggest:

The status field is only for displaying to humans as a hint about the query's state on the server. It is not in sync in the query state from the client's perspective and must not be used to determine whether the query is finished.

Instead, the code should be checking for a 503.

@thedillonb thedillonb changed the title Code does not follow Presto HTTP Best Practicies Code does not follow Presto HTTP Best Practices May 12, 2016
@tagomoris
Copy link
Owner

Oh, it's a bit new document!
I don't have enough time to update this library, but pull-requests are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants