Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: support kerberos authentication #47

Closed
johnson-liang opened this issue May 10, 2021 · 1 comment · Fixed by #48
Closed

Discussion: support kerberos authentication #47

johnson-liang opened this issue May 10, 2021 · 1 comment · Fixed by #48

Comments

@johnson-liang
Copy link

johnson-liang commented May 10, 2021

I am trying to connect to a Trino server guarded with Kerberos authentication.

Currently the authorization header is designated here, in HTTP basic auth: https://github.com/tagomoris/presto-client-node/blob/master/lib/presto-client/index.js#L98

I think there are 2 ways to implement Kerberos support:

  1. Introduce a new option custom_auth in Client constructor opts for a custom authorization header string. When present, it will set authorization header as specified somewhere near here in the code. Developers must find their own way to generate the authorization header (for Kerberos it means using other libraries like kerberos or krb5.)
  2. Introduce an optional dependency kerberos and support kerberos authentication similar to PyHive's.

Personally I prefer 1 because it introduces less code change on the library. If this is preferred, I can submit a pull request on this :)

@tagomoris
Copy link
Owner

@johnson-liang That idea sounds nice to me too :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants