-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 2 support #1179
Drop Python 2 support #1179
Conversation
Temporarily switch image building to always happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I left some comments inline.
@@ -201,8 +188,7 @@ def read_version_py(infname): | |||
"Natural Language :: English", | |||
"Programming Language :: C", | |||
"Programming Language :: Python", | |||
"Programming Language :: Python :: 2", | |||
"Programming Language :: Python :: 2.7", | |||
"Programming Language :: Python :: 3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any best practices for when to include minor version numbers too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷 not sure anyone actually looks at these anymore, the python_requires
is the important bit.
Not sure what's up on macOS. Will have to spin up tahoe dev environment on my macOS VM I guess :( |
I am now looking at
These replacements mostly seem pretty good. One thing that stands out looking at this list is that we're not very consistent in whether we pick And now I have clicked the "Save changes" button. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3873
Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3327
https://www.youtube.com/watch?v=aiwA0JrGfjA