Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDDL-based schema validation for the HTTP storage server #1190

Merged
merged 7 commits into from
Apr 13, 2022
Merged

CDDL-based schema validation for the HTTP storage server #1190

merged 7 commits into from
Apr 13, 2022

Conversation

itamarst
Copy link
Collaborator

@itamarst itamarst requested a review from a team April 12, 2022 16:55
@coveralls
Copy link
Collaborator

coveralls commented Apr 12, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.006%) to 94.698% when pulling bbba75e on 3802-cddl into 4f4c9d6 on master.

exarkun
exarkun approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@exarkun exarkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just minor comments inline.

docs/proposed/http-storage-node-protocol.rst Outdated Show resolved Hide resolved
docs/proposed/http-storage-node-protocol.rst Outdated Show resolved Hide resolved
src/allmydata/storage/http_client.py Show resolved Hide resolved
@exarkun
Copy link
Member

exarkun commented Apr 13, 2022

#1192 should fix the Nix build failures

@itamarst itamarst merged commit 0c18dca into master Apr 13, 2022
@itamarst itamarst deleted the 3802-cddl branch April 13, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exarkun exarkun exarkun approved these changes

Assignees
No one assigned
Labels
HTTP Storage Protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itamarst @coveralls @exarkun