-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable C version of cbor2 loading #1356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I actually have CBOR deserialization working in Rust, which won't have the downside of being much slower, so maybe I'll update the PR to use that? |
Apparently pycddl isn't working on PyPy 😢 |
Going to have to figure out what's up with PyPy, at first glance it seems like a PyO3 bug, will see. |
Obviously we don't want to break PyPy for this, but otherwise looks fine |
PyPy will be fixed with |
enarx/ciborium#97 implies some potential issues with the underlying Rust CBOR library, but...
So 🤷 |
Errors seem... unrelated? Will rerun when final ones finish. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/4088
Update: switched to Rust-based deserialization. I'm hoping to make it run faster, too, in an upcoming release (right now it needs to parse CBOR twice, but that's fixable).