Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicit path to tahoe.cfg in creation message #412

Merged
merged 1 commit into from
Apr 10, 2017

Conversation

tpltnt
Copy link
Contributor

@tpltnt tpltnt commented Apr 7, 2017

Hi there,

I changed the message of tahoe create-client to be explicit about the location of the configuration file. The old message is:

Node created in '/home/foo/.tahoe'
 Please set [client]introducer.furl= in tahoe.cfg!
 The node cannot connect to a grid without it.
 Please set [node]nickname= in tahoe.cfg

The new message is:

(venv)foo% tahoe create-client                           
Node created in '/home/foo/.tahoe'
 Please set [client]introducer.furl= in '/home/foo/.tahoe/tahoe.cfg'!
 The node cannot connect to a grid without it.
 Please set [node]nickname= in '/home/foo/.tahoe/tahoe.cfg'

This should speed up locating the tahoe.cfg file for newcomers.

Cheers,
tpltnt

@codecov-io
Copy link

codecov-io commented Apr 7, 2017

Codecov Report

Merging #412 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
- Coverage   88.02%   88.01%   -0.02%     
==========================================
  Files         146      146              
  Lines       27577    27577              
  Branches     3921     3921              
==========================================
- Hits        24276    24272       -4     
- Misses       2594     2600       +6     
+ Partials      707      705       -2
Impacted Files Coverage Δ
src/allmydata/scripts/create_node.py 98.4% <100%> (ø) ⬆️
src/allmydata/util/dictutil.py 97.19% <0%> (-0.71%) ⬇️
src/allmydata/mutable/servermap.py 93.71% <0%> (-0.33%) ⬇️
src/allmydata/web/status.py 83.27% <0%> (-0.12%) ⬇️
src/allmydata/windows/inotify.py 0% <0%> (ø) ⬆️
src/allmydata/util/encodingutil.py 87.95% <0%> (ø) ⬆️
src/allmydata/windows/fixups.py 0% <0%> (ø) ⬆️
src/allmydata/immutable/checker.py 88.46% <0%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f1dd95...63bcc07. Read the comment docs.

@warner
Copy link
Member

warner commented Apr 10, 2017

Looks good.. I've added a cleanup patch (run quote_local_unicode_path() on the whole path to tahoe.cfg, rather than running it on just the directory and then stripping just one of the quotes to make things line up). Will land momentarily. Thanks!

@warner warner merged commit 63bcc07 into tahoe-lafs:master Apr 10, 2017
@tpltnt tpltnt deleted the create_node_message_path branch April 11, 2017 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants