Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu 20.04 #768

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Add Ubuntu 20.04 #768

merged 2 commits into from
Aug 10, 2020

Conversation

exarkun
Copy link
Member

@exarkun exarkun commented Aug 7, 2020

https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3328

I started off dropping 16.04 as well but then I realize it's LTS for a while longer so we shouldn't be too casual about dropping it.

@exarkun exarkun changed the title De-support Ubuntu 16.04 and add support for Ubuntu 20.04 Add Ubuntu 20.04 Aug 7, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2020

Codecov Report

Merging #768 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
+ Coverage   91.24%   91.26%   +0.01%     
==========================================
  Files         155      155              
  Lines       27223    27223              
  Branches     3871     3871              
==========================================
+ Hits        24839    24844       +5     
+ Misses       1662     1659       -3     
+ Partials      722      720       -2     
Impacted Files Coverage Δ
src/allmydata/web/status.py 94.92% <0.00%> (+0.22%) ⬆️
src/allmydata/mutable/servermap.py 94.22% <0.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d70a78...083be5f. Read the comment docs.

Copy link
Member

@sajith sajith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, tests pass!

- "ubuntu-20.04"
- "ubuntu-18.04":
requires:
- "ubuntu-20.04"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, why is this requires used here? Does this mean that we don't want to test on Ubuntu 18.04 if testing on Ubuntu 20.04 fails?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, essentially. In a perfect world I don't think we'd do this but in a highly CI-resource-constrained world I think it makes sense. I'm sure Ubuntu 20.04 working is not perfectly correlated with Ubuntu 18.04 working but my guess is it's pretty highly correlated and that often the failures are the same. So don't bother spending CI resources on 18.04 if 20.04 is broken. It would be pretty interesting to collect some data on this but I haven't.

@exarkun exarkun merged commit fe2332c into master Aug 10, 2020
@exarkun exarkun deleted the 3328.ubuntu-2004 branch August 10, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants