-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ubuntu 20.04 #768
Add Ubuntu 20.04 #768
Conversation
902aaac
to
083be5f
Compare
Codecov Report
@@ Coverage Diff @@
## master #768 +/- ##
==========================================
+ Coverage 91.24% 91.26% +0.01%
==========================================
Files 155 155
Lines 27223 27223
Branches 3871 3871
==========================================
+ Hits 24839 24844 +5
+ Misses 1662 1659 -3
+ Partials 722 720 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, tests pass!
- "ubuntu-20.04" | ||
- "ubuntu-18.04": | ||
requires: | ||
- "ubuntu-20.04" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, why is this requires
used here? Does this mean that we don't want to test on Ubuntu 18.04 if testing on Ubuntu 20.04 fails?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, essentially. In a perfect world I don't think we'd do this but in a highly CI-resource-constrained world I think it makes sense. I'm sure Ubuntu 20.04 working is not perfectly correlated with Ubuntu 18.04 working but my guess is it's pretty highly correlated and that often the failures are the same. So don't bother spending CI resources on 18.04 if 20.04 is broken. It would be pretty interesting to collect some data on this but I haven't.
https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3328
I started off dropping 16.04 as well but then I realize it's LTS for a while longer so we shouldn't be too casual about dropping it.