You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sometimes we are able to show $ price on the swap screen but on the transaction screen we are losing it.
It happens because swaps screen is using checkCurrencyAmount that will fetch the prices if there are no recent prices saved on the asset. Transaction screen is using saved recent prices which may be empty for some assets.
We should ensure that if prices are fetched then they are saved/cached so we can avoid problems like that and just use one method to get $ price where needed instead of having multiple ways to do the same thing which is causing bugs and problems.
Sometimes we are able to show $ price on the swap screen but on the transaction screen we are losing it.
It happens because swaps screen is using checkCurrencyAmount that will fetch the prices if there are no recent prices saved on the asset. Transaction screen is using saved recent prices which may be empty for some assets.
We should ensure that if prices are fetched then they are saved/cached so we can avoid problems like that and just use one method to get $ price where needed instead of having multiple ways to do the same thing which is causing bugs and problems.
Screen.Recording.2023-05-25.at.11.12.31.mov
Originally posted by @jagodarybacka in #3392 (comment)
The text was updated successfully, but these errors were encountered: