Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing $ price on swap transaction screen #3406

Open
jagodarybacka opened this issue May 25, 2023 · 0 comments
Open

Missing $ price on swap transaction screen #3406

jagodarybacka opened this issue May 25, 2023 · 0 comments
Assignees
Labels
Type: Bug Something isn't working

Comments

@jagodarybacka
Copy link
Contributor

jagodarybacka commented May 25, 2023

Sometimes we are able to show $ price on the swap screen but on the transaction screen we are losing it.

It happens because swaps screen is using checkCurrencyAmount that will fetch the prices if there are no recent prices saved on the asset. Transaction screen is using saved recent prices which may be empty for some assets.

We should ensure that if prices are fetched then they are saved/cached so we can avoid problems like that and just use one method to get $ price where needed instead of having multiple ways to do the same thing which is causing bugs and problems.

Screen.Recording.2023-05-25.at.11.12.31.mov

Originally posted by @jagodarybacka in #3392 (comment)

@jagodarybacka jagodarybacka added the Type: Bug Something isn't working label May 25, 2023
@jagodarybacka jagodarybacka self-assigned this May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant