Sepolia support - small fixes #3636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've added a new class, `TahoAlchemyProvider`, but haven't explained in code why is it needed. Now we add a comment with the explenation.
We're going to use `testnet` protocol for both L1 and L2 testnets.
It makes more sense to display the assets price on the Arbitrum Sepolia testnet based on Arbitrum network prices rather than Ethereum (as Arbitrum Sepolia is designed to mimic the Arbitrum One network).
michalinacienciala
changed the title
jagodarybacka
previously approved these changes
Oct 5, 2023
| // upcoming patch, but as it's release date is unknown, we're adding the Sepolia | ||
| // support by creating `TahoAlchemyProvider` class that handles this case. | ||
| // In the future we may want to add there another case, for `arbitrum-sepolia`, | ||
| // but we can't do that at this moment, as Alchemy dos not offers an RPC for |
There was a problem hiding this comment.
Suggested change
| // but we can't do that at this moment, as Alchemy dos not offers an RPC for | |
| // but we can't do that at this moment, as Alchemy does not offer an RPC for |
There was a problem hiding this comment.
Fixed in cfb1708.
|
The e2e test in this PR will fail, but this is unrelated to the changes in the PR - the tests failures are caused by the fact that we are in the middle of switching to different testing accounts. |
Merged
Shadowfiend
added a commit
that referenced
this pull request
Oct 18, 2023
## What's Changed * v0.49.0 by @Shadowfiend in #3625 * Run pledge sync daily by @michalinacienciala in #3626 * Add support for Mainnet Sepolia and Arbitrum Sepolia testnets by @michalinacienciala in #3633 * Sepolia support - small fixes by @michalinacienciala in #3636 * Update e2e tests after change of testing accounts by @michalinacienciala in #3639 **Full Changelog**: v0.49.0...v0.50.0 Latest build: [extension-builds-3643](https://github.com/tahowallet/extension/suites/17356530333/artifacts/991818546) (as of Wed, 18 Oct 2023 10:26:11 GMT).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we address the leftover comments from the review of #3633 (Add support for Mainnet Sepolia and Arbitrum Sepolia testnets).
Latest build: extension-builds-3636 (as of Mon, 09 Oct 2023 09:24:16 GMT).