v0.49.0

[Shadowfiend]

Highlights

• Fixed an issue where valid private keys would not be accepted. These always had one or more 0s at the beginning.
• Fixed an issue where certain types of errors were causing sites not to load correctly.

What's Changed

• v0.48.0 by @Shadowfiend in v0.48.0 #3610
• Attempt to import private key to validate it by @jagodarybacka in Attempt to import private key to validate it #3614
• Group private keys when categorizing by @Shadowfiend in Group private keys when categorizing #3618
• Assert URL of the scan website opened for unverified assets by @michalinacienciala in Assert URL of the scan website opened for unverified assets #3602
• Handle invalid responses on batch rpc providers by @hyphenized in Handle invalid responses on batch rpc providers #3615
• Joint Privacy: Rework analytics service event management and add signing tracking by @Shadowfiend in Joint Privacy: Rework analytics service event management and add signing tracking #3623

Full Changelog: v0.48.0...v0.49.0

Latest build: extension-builds-3625 (as of Thu, 07 Sep 2023 20:56:50 GMT).

[github-actions]

Release checklist

This release checklist should be performed before release is published.

• dev tests should be performed by the dev team
• if something is not working please create an issue and link it here. Checkbox should be checked only if everything was fine
• in case of serious issues or doubts you should ask the team first

Don't forget to approve the PR when checklist is finished ✅

---

Dev tests

🚀 Version update

• update from previous version with some accounts loaded

---

Manual tests

📨 Add account

1. Add read-only account with ENS
   • check assets
   • check balance
   • check NFTs
   • check abilities (abilities should not be displayed)
   • check activities
   • check portfolio page
   • check export options (export recovery phase and export private key should not be available)
2. Add read-only account with UNS
   • check assets
   • check balance
   • check NFTs
   • check abilities (abilities should not be displayed)
   • check activities
   • check portfolio page
   • check export options (export recovery phase and export private key should not be available)
3. Add read-only account with 0x address
   • check assets
   • check balance
   • check NFTs
   • check abilities (abilities should not be displayed)
   • check activities
   • check portfolio page
   • check export options (export recovery phase and export private key should not be available)
4. Import account with a seed phrase
   • check assets
   • check balance
   • check NFTs
   • check abilities
   • check activities
   • check portfolio page
   • check seed phrase export
   • check private key export for first account
5. Add another account from the same seed phrase
   • check assets
   • check balance
   • check NFTs
   • check abilities
   • check activities
   • check portfolio page
   • check private key export for second account
6. Add account with a Ledger
   • check assets
   • check balance
   • check NFTs
   • check abilities
   • check activities
   • check portfolio page
   • check export options (export recovery phase and export private key should not be available)
7. Create new wallet
   • check assets
   • check balance
   • check NFTs
   • check abilities
   • check activities
   • check portfolio page
   • check private key export
8. Add account with private key
   • check assets
   • check balance
   • check NFTs
   • check abilities
   • check activities
   • check portfolio page
   • check private key export
9. Add account with JSON keystore
   • check assets
   • check balance
   • check NFTs
   • check abilities
   • check activities
   • check portfolio page
   • check private key export

🗑️ Remove account

1. Remove account by type
   • remove read-only account
   • remove address from imported account
   • remove Ledger account
   • remove account imported with private key
   • remove account imported with JSON keystore
   • remove selected account
   • remove not selected account
   • remove all accounts
2. Remove account and check functionalities
   • add removed address from imported account
   • remove all addresses from imported account
   • check if NFTs are removed for removed accounts
   • check if abilities are removed for removed accounts
   • check if Portfolio page is updated for removed accounts

💌 Send base asset

1. Ethereum mainnet
   • check gas settings and gas price
   • sign
   • check transaction on scan website
2. Polygon
   • check gas settings and gas price
   • sign
   • check transaction on scan website
3. Optimism
   • check gas settings and gas price
   • sign
   • check transaction on scan website
4. Arbitrum
   • check gas settings and gas price
   • sign
   • check transaction on scan website
5. Avalanche
   • check gas settings and gas price
   • sign
   • check transaction on scan website
6. Binance Smart Chain
   • check gas settings and gas price
   • sign
   • check transaction on scan website

🎁 Send ERC20

1. Ethereum mainnet
   • check gas settings and gas price
   • sign
   • check transaction on scan website
2. Polygon
   • check gas settings and gas price
   • sign
   • check transaction on scan website
3. Optimism
   • check gas settings and gas price
   • sign
   • check transaction on scan website
4. Arbitrum
   • check gas settings and gas price
   • sign
   • check transaction on scan website
5. Avalanche
   • check gas settings and gas price
   • sign
   • check transaction on scan website
6. Binance Smart Chain
   • check gas settings and gas price
   • sign
   • check transaction on scan website

💸 Internal swap

1. Ethereum mainnet
   • check token list
   • sign token spend approval
   • check gas settings and gas price
   • sign
   • check transaction on scan website
2. Polygon
   • check token list
   • sign token spend approval
   • check gas settings and gas price
   • sign
   • check transaction on scan website
3. Optimism
   • check token list
   • sign token spend approval
   • check gas settings and gas price
   • sign
   • check transaction on scan website
4. Arbitrum
   • check token list
   • sign token spend approval
   • check gas settings and gas price
   • sign
   • check transaction on scan website
5. Avalanche
   • check token list
   • sign token spend approval
   • check gas settings and gas price
   • sign
   • check transaction on scan website
6. Binance Smart Chain
   • check token list
   • sign token spend approval
   • check gas settings and gas price
   • sign
   • check transaction on scan website

📡 dApps connections

• connect to Uniswap
• connect to Opensea
• connect to Galxe
• connect to PancakeSwap
• connect to TraderJoe
• connect to SpookySwap
• connect to Velodrome
• connect to GMX
• connect to MetaMask Test dApp & verify Personal Sign

🎭 Sign in with Ethereum

• SIWE on login.xyz
• SIWE on Taho Pledge

🐶 Default wallet

1. Default wallet setting turned OFF
   • connect with dapp without MM available using Taho
   • connect with dapp with MM available using MM
2. Default wallet setting turned ON
   • connect with dapp without MM available using Taho
   • connect with dapp with MM available using Taho

⚙️ Settings

• check hide balance under $2 option
• check bug reports - export logs
• check connected dapp - confirm you are able to disconnect from a dapp

☀️ Abilities

• check each filter option
• delete ability
• mark ability as completed

🌠 NFTs page

1. NFTs page
   • browse NFTs
   • expand and collapse collection
   • check NFT preview
   • check Badges tab
2. NFTs filters
   • check each sort type
   • disable account
   • disable collection

🦾 Flashbots

1. Enable Flashbots in settings:
   • send/swap an asset & confirm trxn on Ethereum shows the Flashbots option with it auto-selected
   • confirm trxn is then sent through Flashbots
   • send/swap another asset deselect Flashbots option
   • confirm that trxn is not sent through Flashbots
2. Check trxns on other networks
   • confirm Flashbots checkbox isn't shown at all
   • confirm trxn is not sent through Flashbots
3. Disable Flashbots option in settings
   • send/swap an asset on Ethereum & confirm trxn shows without the Flashbots option
   • confirm trxn is not sent through Flashbots

[andreachapman]

I noted some issues in Discord (https://discord.com/channels/1079490158639976609/1149348577265602631) with connecting to dapps but then I did all of those again in Brave without any issues. Also, in Chrome I was having the same connection issues on the current prod version which I know with certainty wasn't happening last week when I did this testing. So my current theory is that there isn't an issue with this version but that I'm experiencing some conflicts due to the fact that I've had multiple versions installed over the past few days and have been testing each.
As far as I can tell, this release is good to go.

Also, just an interesting note: the testing I did on Abilities I also did in Brave and had no issues completing and deleting the abilities. In the 0.48.0 release, I noted that I was having a lot of trouble in that area. I had logged that here: #3624

[Shadowfiend]

Interesting that the abilities stuff isn't manifesting now yeah… Need to ponder that a bit more 🤔