Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e2e tests after change of testing accounts #3639

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

michalinacienciala
Copy link
Contributor

@michalinacienciala michalinacienciala commented Oct 9, 2023

We've rotated the wallets used for testing of the extension and moved some of the assets. The GH secrets got already updated accordingly, we now need to update the addresses of wallets and change some other values used in tests, to fit the assets that we have on the new testing wallets. Changes include:

  • switching of e2e.testertesting.eth wallet from 0x6f1b1f1feb01235e15a7962f16c389c7f8218ed6 to 0x9d373acbe8540895fa1752ab463ab31bbab2b38f
  • switching of testertesting.eth wallet from 0x0581470a8b62bd35dbf121a6329d43e7edd20fc7 to 0x6e80164ea60673d64d5d6228beb684a1274bb017
  • changing the POAP used in the NFTs tests
  • changing the number of a forking block (the new testing wallet didn't have any assets yet on an old forking block) and switching to a different asset used in tests of ERC-20 transfers.

Latest build: extension-builds-3639 (as of Thu, 12 Oct 2023 09:24:36 GMT).

@michalinacienciala michalinacienciala self-assigned this Oct 9, 2023
@michalinacienciala michalinacienciala force-pushed the update-e2e-after-accounts-change branch 2 times, most recently from 2a568aa to a3ba079 Compare October 9, 2023 08:54
We've rotated the wallets used for testing of the extension and moved some of
the assets. The GH secrets got already updated accordingly, we now need to
update the addresses of wallets and change some other values used in tests, to
fit the assets that we have on the new testing wallets.
Changes include:
* switching of `e2e.testertesting.eth` wallet from
  `0x6f1b1f1feb01235e15a7962f16c389c7f8218ed6` to
  `0x9d373acbe8540895fa1752ab463ab31bbab2b38f`
* switching of `testertesting.eth` wallet from
  `0x0581470a8b62bd35dbf121a6329d43e7edd20fc7` to
  `0x6e80164ea60673d64d5d6228beb684a1274bb017`
* changing the POAP used in the NFTs tests
* changing the number of a forking block (the new testing wallet didn't have any
  assets yet on an old forking block) and switching to a different asset used in
  tests of ERC-20 transfers.
@michalinacienciala michalinacienciala marked this pull request as ready for review October 9, 2023 10:34
@michalinacienciala michalinacienciala requested a review from a team October 9, 2023 10:36
Copy link
Contributor

@jagodarybacka jagodarybacka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goood 🚀

@jagodarybacka jagodarybacka merged commit 7c55e6d into main Oct 10, 2023
5 of 6 checks passed
@jagodarybacka jagodarybacka deleted the update-e2e-after-accounts-change branch October 10, 2023 12:38
@jagodarybacka jagodarybacka mentioned this pull request Oct 18, 2023
Shadowfiend added a commit that referenced this pull request Oct 18, 2023
## What's Changed
* v0.49.0 by @Shadowfiend in
#3625
* Run pledge sync daily by @michalinacienciala in
#3626
* Add support for Mainnet Sepolia and Arbitrum Sepolia testnets by
@michalinacienciala in #3633
* Sepolia support - small fixes by @michalinacienciala in
#3636
* Update e2e tests after change of testing accounts by
@michalinacienciala in #3639


**Full Changelog**:
v0.49.0...v0.50.0

Latest build:
[extension-builds-3643](https://github.com/tahowallet/extension/suites/17356530333/artifacts/991818546)
(as of Wed, 18 Oct 2023 10:26:11 GMT).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants