Sepo-Ledger: Patch @ledgerhq/hw-app-eth for Arbitrum Sepolia chain id handling #3650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It currently seems like there is an issue with Ledger's handling of high chain ids for certain transactions, where the Ledger can provide a first byte that breaks the expectations of the chain id adjustment done for legacy transactions to conform to EIP-155. The resulting `v` value returned from the signing flow is invalid and Ethers throws because of this. This fix *may* be correct, but it may not be. To adjust for this fact, the patch limits adjustments of the underlying parity value in ledger to happen only when the chain id matches Arbitrum Sepolia's (412614).
There was a problem hiding this comment.
Looks good, only this comparison is worrying me a bit. I'll let @andreachapman and @michalinacienciala QA it before merging (unless we want to QA it all in one batch on the release)
Merged
Shadowfiend
added a commit
that referenced
this pull request
Nov 7, 2023
## What's Changed * v0.50.0 by @jagodarybacka in #3643 * Unsettled Networks: Clear an origin's current network when revoking dApp permissions by @Shadowfiend in #3616 * Sepo-Ledger: Patch @ledgerhq/hw-app-eth for Arbitrum Sepolia chain id handling by @Shadowfiend in #3650 * Proxy Wars: More QoL improvements for dApp connections by @Shadowfiend in #3613 **Full Changelog**: v0.50.0...v0.51.0 Latest build: [extension-builds-3652](https://github.com/tahowallet/extension/suites/17870144186/artifacts/1025746882) (as of Fri, 03 Nov 2023 02:06:50 GMT).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It currently seems like there is an issue with Ledger's handling of high chain ids for certain transactions, where the Ledger can provide a first byte that breaks the expectations of the chain id adjustment done for legacy transactions to conform to EIP-155. The resulting
vvalue returned from the signing flow is invalid and Ethers throws because of this.This fix may be correct, but it may not be. To adjust for this fact, the patch limits adjustments of the underlying parity value in Ledger to happen only when the chain id matches Arbitrum Sepolia's (412614), as that's the only place we've seen consistent reports of the issue.
See also LedgerHQ/ledger-live#5265 .
Fixes #3647 .
Testing
Latest build: extension-builds-3650 (as of Thu, 02 Nov 2023 02:14:12 GMT).