Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.51.0 #3652

Merged
merged 2 commits into from
Nov 7, 2023
Merged

v0.51.0 #3652

merged 2 commits into from
Nov 7, 2023

Conversation

Shadowfiend
Copy link
Contributor

@Shadowfiend Shadowfiend commented Nov 3, 2023 •
edited by github-actions bot
Loading

What's Changed

Full Changelog: v0.50.0...v0.51.0

Latest build: extension-builds-3652 (as of Tue, 07 Nov 2023 19:04:41 GMT).

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023 •
edited by andreachapman
Loading

Release checklist

This release checklist should be performed before release is published.

  • dev tests should be performed by the dev team
  • if something is not working please create an issue and link it here. Checkbox should be checked only if everything was fine
  • in case of serious issues or doubts you should ask the team first

Don't forget to approve the PR when checklist is finished ✅

Dev tests

🚀 Version update

  • update from previous version with some accounts loaded

Manual tests

📨 Add account

  1. Add read-only account with ENS
    • check assets
    • check balance
    • check NFTs
    • check abilities (abilities should not be displayed)
    • check activities
    • check portfolio page
    • check export options (export recovery phase and export private key should not be available)
  2. Add read-only account with UNS
  3. Add read-only account with 0x address
    • check assets
    • check balance
    • check NFTs
    • check abilities (abilities should not be displayed)
    • check activities
    • check portfolio page
    • check export options (export recovery phase and export private key should not be available)
  4. Import account with a seed phrase
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check seed phrase export
    • check private key export for first account
  5. Add another account from the same seed phrase
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check private key export for second account
  6. Add account with a Ledger (found bug: Problems with importing Ledger account when proceeding before entering Ethereum app #3655, not release-related)
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check export options (export recovery phase and export private key should not be available)
  7. Create new wallet
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check private key export
  8. Add account with private key
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check private key export
  9. Add account with JSON keystore
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check private key export

🗑️ Remove account

  1. Remove account by type
    • remove read-only account
    • remove address from imported account
    • remove Ledger account
    • remove account imported with private key
    • remove account imported with JSON keystore
    • remove selected account
    • remove not selected account
    • remove all accounts
  2. Remove account and check functionalities
    • add removed address from imported account
    • remove all addresses from imported account
    • check if NFTs are removed for removed accounts
    • check if abilities are removed for removed accounts
    • check if Portfolio page is updated for removed accounts

💌 Send base asset

  1. Ethereum mainnet
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  2. Polygon
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  3. Optimism
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  4. Arbitrum
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  5. Avalanche
  6. Binance Smart Chain
    • check gas settings and gas price
    • sign
    • check transaction on scan website

🎁 Send ERC20

  1. Ethereum mainnet
    • check gas settings and gas price
    • sign
    • check transaction on scan website (🔴 tx was on the scan website, but not in the wallet's history)
  2. Polygon
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  3. Optimism
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  4. Arbitrum
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  5. Avalanche
  6. Binance Smart Chain
    • check gas settings and gas price
    • sign
    • check transaction on scan website

💸 Internal swap

  1. Ethereum mainnet (！gas estimate was very high preventing us from testing on mainnet so did a swap on Goerli instead and it was successful)
  2. Polygon
  3. Optimism
    • check token list
    • sign token spend approval (🔴 in one of the tests tx did not appear in wallet history, 🟡 had to fill the swap form again afterwards)
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  4. Arbitrum
    • check token list
    • sign token spend approval (🟡 gas-related error in logs)
    • check gas settings and gas price
    • sign (🟡 gas-related error in logs)
    • check transaction on scan website
  5. Avalanche
    • check token list
    • sign token spend approval (🟡 had to fill the swap form again afterwards)
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  6. Binance Smart Chain

📡 dApps connections

🎭 Sign in with Ethereum

🐶 Default wallet

  1. Default wallet setting turned OFF
    • connect with dapp without MM available using Taho
    • connect with dapp with MM available using MM
  2. Default wallet setting turned ON
    • connect with dapp without MM available using Taho
    • connect with dapp with MM available using Taho

⚙️ Settings

  • check hide balance under $2 option
  • check bug reports - export logs
  • check connected dapp - confirm you are able to disconnect from a dapp

☀️ Abilities

  • check each filter option
  • delete ability
  • mark ability as completed

🌠 NFTs page

  1. NFTs page
    • browse NFTs
    • expand and collapse collection
    • check NFT preview
    • check Badges tab
  2. NFTs filters
    • check each sort type
    • disable account
    • disable collection

🦾 Flashbots

  1. Enable Flashbots in settings:
    • send/swap an asset & confirm trxn on Ethereum shows the Flashbots option with it auto-selected
    • confirm trxn is then sent through Flashbots
    • send/swap another asset deselect Flashbots option
    • confirm that trxn is not sent through Flashbots
  2. Check trxns on other networks
    • confirm Flashbots checkbox isn't shown at all
    • confirm trxn is not sent through Flashbots
  3. Disable Flashbots option in settings
    • send/swap an asset on Ethereum & confirm trxn shows without the Flashbots option
    • confirm trxn is not sent through Flashbots

@michalinacienciala michalinacienciala mentioned this pull request Nov 3, 2023
Closed
@michalinacienciala
Copy link
Contributor

michalinacienciala commented Nov 3, 2023 •
edited
Loading

[EDIT]: I couldn't reproduce the below issues after reinstalling the wallet.

I've encountered some problems during testing which don't occur for me on 0.50.0:

Issue 1

Can't connect to Galxe when 'connect using Taho' is selected in Taho wallet and I choose MM option in Galxe (no matter if I have MM installed or not). Galxe's logs show:

Please connect to MetaMask.
{code: 4001, message: 'The user rejected the request.'}

It may be connected to the fact that Galxe seems to be set to Goerli for me:
image
And when I try to change the setting to other network, I get this:
image

The behavior does not differ depending on the network selected in the wallet (I checked for Ethereum, Goerli, Optimism)

Issue 2

Can't connect on SpookySwap with MM option as well . In their logs I see The requested method and/or account has not been authorized by the user.

andreachapman
andreachapman approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@andreachapman andreachapman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. There are some tests not checked off due to issues Michalina found and logged but we've talked through everything and nothing is a blocker.

@Shadowfiend Shadowfiend merged commit 0de6925 into main Nov 7, 2023
5 of 6 checks passed
@Shadowfiend Shadowfiend deleted the release-0.51.0 branch November 7, 2023 18:45
@jagodarybacka jagodarybacka mentioned this pull request Nov 22, 2023
Merged
Shadowfiend added a commit that referenced this pull request Nov 23, 2023
@Shadowfiend
v0.52.0 (#3678)
4fe9acf 
## What's Changed
* Check connecting to dapp on different network after disconnecting by
@michalinacienciala in #3654
* v0.51.0 by @Shadowfiend in
#3652
* Fix typos by @xiaolou86 in
#3668
* Alchemic Logs: Small improvements for eth_getLogs by @Shadowfiend in
#3664
* Fix getting currently connected dapp info by @jagodarybacka in
#3671
* Add static subcape link to the wallet by @jagodarybacka in
#3670
* Fix e2e tests by @michalinacienciala in
#3651
* Add Alchemy endpoint for Arbitrum Sepolia by @jagodarybacka in
#3665
* Do notify: Set up base NotificationService by @Shadowfiend in
#3666

## New Contributors
* @xiaolou86 made their first contribution in
#3668

**Full Changelog**:
v0.51.0...v0.52.0

Latest build:
[extension-builds-3678](https://github.com/tahowallet/extension/suites/18415208655/artifacts/1067210815)
(as of Wed, 22 Nov 2023 14:53:11 GMT).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreachapman andreachapman andreachapman approved these changes

@michalinacienciala michalinacienciala Awaiting requested review from michalinacienciala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Shadowfiend @michalinacienciala @andreachapman