Unsettled Networks: Clear an origin's current network when revoking dApp permissions #3616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actual implementation is a little more subtle: permissions are for an origin AND a network. If the permission being cleared is for the origin's current network, as tracked in the `InternalEthereumProvider`, then that current network is cleared so that future interactions can set it.
|
Going to turbo this one so we can look at everything in #3613 . |
Merged
Shadowfiend
added a commit
that referenced
this pull request
Nov 7, 2023
## What's Changed * v0.50.0 by @jagodarybacka in #3643 * Unsettled Networks: Clear an origin's current network when revoking dApp permissions by @Shadowfiend in #3616 * Sepo-Ledger: Patch @ledgerhq/hw-app-eth for Arbitrum Sepolia chain id handling by @Shadowfiend in #3650 * Proxy Wars: More QoL improvements for dApp connections by @Shadowfiend in #3613 **Full Changelog**: v0.50.0...v0.51.0 Latest build: [extension-builds-3652](https://github.com/tahowallet/extension/suites/17870144186/artifacts/1025746882) (as of Fri, 03 Nov 2023 02:06:50 GMT).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft until I fill in some testing details.
The actual implementation is a little more subtle: permissions are for an origin AND a network. If the permission being cleared is for the origin's current network, as tracked in the
InternalEthereumProvider, then that current network is cleared so that future interactions can set it.Latest build: extension-builds-3616 (as of Sat, 02 Sep 2023 20:14:11 GMT).