Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removing custom networks #3699

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Conversation

jagodarybacka
Copy link
Contributor

@jagodarybacka jagodarybacka commented Dec 13, 2023

Resolves #3685

What

Add database transaction dependency to fix removing items from customRpcConfig table.

Testing

  • add custom network
  • succesfully remove it

Latest build: extension-builds-3699 (as of Thu, 14 Dec 2023 10:42:19 GMT).

Add database transaction dependency to fix removing items from
`customRpcConfig` table.
Copy link
Contributor

@michalinacienciala michalinacienciala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks OK. Was able to add custom network and remove it. Tested removing network that was selected and one that wasn't. Also tested adding a network that was previously removed.

@michalinacienciala michalinacienciala merged commit 6cbced5 into main Dec 14, 2023
6 checks passed
@michalinacienciala michalinacienciala deleted the fix-removing-custom-chains branch December 14, 2023 10:33
@xpaczka xpaczka mentioned this pull request Dec 15, 2023
xpaczka added a commit that referenced this pull request Dec 22, 2023
## What's Changed
* Hide Subscape features by @jagodarybacka in
#3697
* Add Subscape realms by adddress not name by @jagodarybacka in
#3695
* Create script to export pledge signers by @jagodarybacka in
#3698
* Fix removing custom networks by @jagodarybacka in
#3699
* Disable listeners on realm contract by @jagodarybacka in
#3701
* v0.53.0 by @Shadowfiend in
#3690
* removed typo from removePreferencesForChain func of
intenralEthtereuemProviderClass by @EggsyOnCode in
#3691
* Check DevTools when executing tests on release testlist by
@michalinacienciala in #3704
* v0.53.1 by @jagodarybacka in
#3702

## New Contributors
* @EggsyOnCode made their first contribution in
#3691

**Full Changelog**:
v0.53.1...v0.54.0

Latest build:
[extension-builds-3706](https://github.com/tahowallet/extension/suites/19076409335/artifacts/1117045278)
(as of Fri, 15 Dec 2023 10:58:26 GMT).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to remove custom networks
2 participants