Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visibility of projected type #81

Closed
taiki-e opened this issue Sep 9, 2019 · 1 comment · Fixed by #96
Closed

Visibility of projected type #81

taiki-e opened this issue Sep 9, 2019 · 1 comment · Fixed by #96
Labels
A-pin-projection Area: #[pin_project] C-enhancement Category: A new feature or an improvement for an existing one

Comments

@taiki-e
Copy link
Owner

taiki-e commented Sep 9, 2019

Currently, visibility of the projected type and projection trait are always pub(self), but we may use the original type visibility (but pub is downgraded to pub(crate))
@taiki-e taiki-e mentioned this issue Sep 9, 2019
Closed
@taiki-e

This comment has been minimized.

Sign in to view
@taiki-e taiki-e changed the title Visibility of projected type and projection trait Visibility of projected type Sep 17, 2019
@taiki-e taiki-e mentioned this issue Sep 19, 2019
Merged
@bors bors bot closed this as completed in #96 Sep 19, 2019
@bors bors bot closed this as completed in 68e783d Sep 19, 2019
@taiki-e taiki-e added C-enhancement Category: A new feature or an improvement for an existing one A-pin-projection Area: #[pin_project] A-project-attribute Area: #[project], #[project_ref], and #[project_replace] (note: this was removed in v1.0) and removed A-project-attribute Area: #[project], #[project_ref], and #[project_replace] (note: this was removed in v1.0) labels Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-pin-projection Area: #[pin_project] C-enhancement Category: A new feature or an improvement for an existing one
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Determine the visibility based on the original type taiki-e/pin-project
1 participant
@taiki-e