Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit MBIDs for ListenBrainz #28

Closed
phw opened this issue Feb 6, 2019 · 1 comment
Closed

Submit MBIDs for ListenBrainz #28

phw opened this issue Feb 6, 2019 · 1 comment
Labels
enhancement Accepted functionality to be added

Comments

@phw
Copy link

phw commented Feb 6, 2019

When submitting to ListenBrainz existing MusicBrainz IDs for the recording, release and artist should be included, if they are available from the files. This way ListenBrainz can exactly identify the played tracks and will link them accordingly.

See docs at https://listenbrainz.readthedocs.io/en/production/dev/json.html#payload-json-details

You can also take a look at the implementation at https://github.com/phw/rhythmbox-plugin-listenbrainz/blob/master/listenbrainz/client.py and re-use this or parts of it. It also handles rate limiting.

I tried to make this ListenBrainz client class as universal as possible to allow reuse (and possible release it separately). So far it has been reused at https://github.com/ijc/quodlibet-listenbrainz-plugin/blob/master/listenbrainz.py and was originally derived from code written for the Lollypop player.

@Taiko2k Taiko2k added the enhancement Accepted functionality to be added label Feb 6, 2019
@Taiko2k
Copy link
Owner

Taiko2k commented Feb 9, 2019

I have this implemented now (For ID3v2, Vorbis and APEv2). Looks like this is working since I'm now getting blue links in the profile on tracks that have the data.
screenshot from 2019-02-09 17-52-47

So this will be working in the next release I do.

@Taiko2k Taiko2k closed this as completed Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Accepted functionality to be added
Projects
None yet
Development

No branches or pull requests

2 participants