Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): Change require strings to custom errors #13057

Closed
cyberhorsey opened this issue Jan 25, 2023 · 4 comments
Closed

feat(protocol): Change require strings to custom errors #13057

cyberhorsey opened this issue Jan 25, 2023 · 4 comments
Assignees
@cyberhorsey
Labels
area.protocol category.enhancement

Comments

@cyberhorsey
Copy link
Contributor

Describe the feature request

Custom Errors are significantly lower on gas and bytes, and would reduce the size and gas costs of our deployments and contract calls by quite a bit.

Describe alternatives you've considered

Description of the alternatives you've considered here.

Additional context

Additional context here.
@cyberhorsey cyberhorsey self-assigned this Jan 25, 2023
@cyberhorsey
Copy link
Contributor Author

@dantaik do you agree?

@dionysuzx dionysuzx changed the title fear(protocl): Change require strings to custom errors fear(protocol): Change require strings to custom errors Jan 25, 2023
@cyberhorsey cyberhorsey changed the title fear(protocol): Change require strings to custom errors feat(protocol): Change require strings to custom errors Jan 26, 2023
@dantaik dantaik linked a pull request Feb 4, 2023 that will close this issue
refactor(protocol): use custom errors #13086
Closed
@dantaik dantaik assigned cyberhorsey and unassigned dantaik Feb 5, 2023
@dantaik
Copy link
Contributor

dantaik commented Feb 12, 2023

@cyberhorsey ,with this PR, maybe we can quickly change all string-based errors to custom errors.

@dantaik
Copy link
Contributor

dantaik commented Feb 12, 2023

With #13146, the outstanding work is changing Bridge contracts to use custom errors.

@dantaik
Copy link
Contributor

dantaik commented Feb 24, 2023

Update: now only the bridge related files have string-based error messages.

@adaki2004 adaki2004 mentioned this issue Feb 27, 2023
Merged
@dantaik dantaik closed this as completed Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cyberhorsey cyberhorsey

Labels
area.protocol category.enhancement
Projects
Taiko Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(protocol): use custom errors taikoxyz/taiko-mono
4 participants
@RogerLamTd @dantaik @davidtaikocha @cyberhorsey