Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: changes in Introduction section of actors_privileges_deployments.md #17064

Closed
1 task done
theothercrowd opened this issue May 9, 2024 · 2 comments
Closed
1 task done

Comments

@theothercrowd
Copy link

theothercrowd commented May 9, 2024

changes in docs

Here's the updated version of Introduction section of actors_privileges_deployments.md:

“This document provides a comprehensive overview of the actors involved in the smart contract system and outlines their respective privileges and roles. Different roles (we call them domains) are granted via the AddressManager contract’s setAddress() function. The idea is very similar to Optimism’s AddressManager, except that we use the chainId + domainName as the key for a given address. We need to do so because, for bridging purposes, the destination chain’s bridge address needs to be included to signal that the message hash is tamper-proof. Every contract which needs some role-based authentication needs to inherit from the AddressResolver contract. This will serve as a ‘middleman/lookup’ by querying the AddressManager to determine if a given address is allowed to act on behalf of that domain or not.”

Changes made:

“domain” to “domains”

“Idea is very similar Optimism’s AddressManager” to “The idea is very similar to Optimism’s AddressManager”

Added “to” in “we need to do so”

“signaling the message hash is tamper-proof” to “to signal that the message hash is tamper-proof” -- with this phrase I'm not quite sure what you wanted to say, but I tried my best to edit that.

Spam policy

  • I verify that this issue is NOT SPAM and understand SPAM issues will be closed and reported to GitHub, resulting in ACCOUNT TERMINATION.
Copy link
Contributor

This issue is stale because it has been open for 30 days with no activity.

Copy link
Contributor

This issue was closed because it has been inactive for a week since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants