Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build System #1

Closed
alrighttheresham opened this issue Oct 22, 2012 · 13 comments
Closed

Build System #1

alrighttheresham opened this issue Oct 22, 2012 · 13 comments

Comments

@alrighttheresham
Copy link
Contributor

Feature Request to move from Ant to Maven Multiproject.

Will allow support out of the box:

  • All IDE configuration files, Eclipse, IDEAJ, etc.
  • Publishing of Milestone releases (versioning)
  • Easier integration of 3rd party dependencies
  • Std project layout
@alrighttheresham
Copy link
Contributor Author

Emil, I have created a skeleton build system using maven, I'll zip it up and send it to you later today.

@klacke
Copy link

klacke commented Oct 23, 2012

This is just a library, it's a simple NETCONF client library, why do we want mvn build system things here. A user of this library will typically have a build system of their own, be it ant, mvn or whatever. I feel we should keep all things maven out of this repo.

@alrighttheresham
Copy link
Contributor Author

Hi Claes, my motivation for moving to maven is to reduce the maintenance overhead. It already has a build system, you'll notice that there are a number of ant configuration files one for JNC and one of each of the example projects. Each are handcrafted and inconsistent across the various projects.

The current solution does not provide a way to gate release the software, is the assumption that there will be no official CA release? As you aware this is a 'free' feature of maven.

I have a provided today a skeleton maven build to Emil for the project for his review, which includes plugins for static analysis and code coverage.

@klacke
Copy link

klacke commented Oct 24, 2012

On 10/23/12 7:42 PM, alrighttheresham wrote:

Hi Claes, my motivation for moving to maven is to reduce the maintenance
overhead. It already has a build system, you'll notice that there are a
number of ant configuration files one for JNC and one of each of the
example projects. Each are handcrafted and inconsistent across the
various projects.

I suggest we fix that then, should be easy. I can do that.

The current solution does not provide a way to gate release the
software, is the assumption that there will be no official CA release?

That also is lacking today, a way to build version numbered, tested
releases.

As you aware this is a 'free' feature of maven.

I have a provided today a skeleton maven build to Emil for the project
for his review, which includes plugins for static analysis and code
coverage.

I've worked with maven in previous projects, and frankly I've never
ever come across any software that I disliked more.
Here - all we need to do - is to build a library, so at least from
my point of view, maven would only be in the way.

/klacke

@alrighttheresham
Copy link
Contributor Author

Hi Klacke, thanks for the response.

Can you also add support for findbugs, pmd, checkstyle and cobertura, to ensure a consistent level of code quality.

Thanks,
Damian.

@klacke
Copy link

klacke commented Oct 24, 2012

On 10/24/12 7:03 PM, alrighttheresham wrote:

Hi Klacke, thanks for the response.

Can you also add support for findbugs, pmd, checkstyle and cobertura, to
ensure a consistent level of code quality.

I haven't used any of the tools mentioned above, maybe they are great,
and maybe it's easier to access them from maven than from ant, ?, but
I've never used them. I have used maven though, and in those projects
maven itself cost us a lot more time than it saved us. A lot. I guess
you have different experiences.

I remember in particular the mess that was the result of automated
testing in an NFS environment where the $HOME/.m2 dir was written
into simultaneously by multiple hosts. At the time there was no way
to have the .m2 somewhere else than $HOME, or there was, but it was
broken. 18 months ago.

OTOH, I guess Emil has the last say here, Just my 2c

/klacke

@amyzwang
Copy link

amyzwang commented Nov 6, 2013

Hi alrighttheresham,

I'm new to JNC, we are looking at the build system using maven, you mentioned you have created a skeleton, any possibility I can have a copy?

Thanks.
Amy

@alrighttheresham
Copy link
Contributor Author

Hi Amy, I supplied this tar directly to Emil with the option to use if they choose too. Since it wasn’t incorporated I can’t guarantee that it still works. I suggest you followup directly with Emil.

Thanks,
Damian.

On 6 Nov 2013, at 23:20, amyzwang notifications@github.com wrote:

Hi alrighttheresham,

I'm new to JNC, we are looking at the build system using maven, you mentioned you have created a skeleton, any possibility I can have a copy?

Thanks.
Amy


Reply to this email directly or view it on GitHub.

@amyzwang
Copy link

amyzwang commented Nov 6, 2013

Thank you Damian.

Hi Emil, we do see the maven build system is useful for JNC library... at least in our use case. Are there any way we can have this tar to try it out?

Thanks,
Amy

@Emil-Tail-f
Copy link
Contributor

Hello Amy!

I have located and updated the tar. I can't find your email address, so please email klacke at tail-f.com and he will make sure that you get it. We have not been using Maven for JNC, but you are welcome to try it out.

Thank you for showing interest in JNC,
Emil Wall.

@klacke
Copy link

klacke commented Nov 8, 2013

Correct, Amy I got the tar file, so if you want it, reach out to me.

klacke pushed a commit that referenced this issue Apr 20, 2014
1) Support for merging configuration. 2) Avoid SAX Parser exception.
@imrepo
Copy link

imrepo commented Mar 2, 2015

Hi Klacke my codition is same like Amy in my case i have to use mvn based library, if possible can i have one copy?

@jomiklos
Copy link
Contributor

jomiklos commented Jan 2, 2023

Should be "resolved" / irrelevant (after 5e0dccc) and moving to Gradle build system/packages/plugins.

@jomiklos jomiklos closed this as completed Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants