Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve merging logic in struct #1701

Closed
coderabbitai bot opened this issue Apr 11, 2024 · 2 comments · Fixed by #1977
Closed

Improve merging logic in struct #1701

coderabbitai bot opened this issue Apr 11, 2024 · 2 comments · Fixed by #1977
Labels
good first issue Good for newcomers. state: inactive No current action needed/possible; issue fixed, out of scope, or superseded.

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 11, 2024

There's a need to improve the merging logic for in the struct to use a more idiomatic Rust approach, avoiding manual index handling. This issue was identified during a PR review. For more context, see the PR at #1699 and the specific comment at #1699 (comment).
@amitksingh1490 amitksingh1490 added the good first issue Good for newcomers. label Apr 14, 2024
@coderabbitai coderabbitai bot mentioned this issue Apr 14, 2024
Merged
6 tasks
@github-actions GitHub Actions
Copy link

Action required: Issue inactive for 30 days.
Status update or closure in 7 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 14, 2024
@TheWizardTower TheWizardTower mentioned this issue May 16, 2024
Merged
6 tasks
@github-actions GitHub Actions
Copy link

Issue closed after 7 days of inactivity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers. state: inactive No current action needed/possible; issue fixed, out of scope, or superseded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Clean up merge logic for vectors of key-value structs. TheWizardTower/tailcall
1 participant
@amitksingh1490