drive: don't allow LOCK and UNLOCK methods

Temporarily disables support for locking until we reimplement it properly.

Updates #12097

Signed-off-by: Percy Wegmann <percy@tailscale.com>

drive/driveimpl/compositedav/compositedav.go

@@ -93,7 +93,11 @@ var cacheInvalidatingMethods = map[string]bool{
 
 // ServeHTTP implements http.Handler.
 func (h *Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
-	if r.Method == "PROPFIND" {
+	switch r.Method {
+	case "LOCK", "UNLOCK":
+		http.Error(w, "locking is not currently supported", http.StatusMethodNotAllowed)
+		return
+	case "PROPFIND":
 		h.handlePROPFIND(w, r)
 		return
 	}

drive/driveimpl/drive_test.go

@@ -145,6 +145,40 @@ func TestSecretTokenAuth(t *testing.T) {
 	}
 }
 
+func TestLocking(t *testing.T) {
+	s := newSystem(t)
+
+	s.addRemote(remote1)
+	s.addShare(remote1, share11, drive.PermissionReadWrite)
+	s.writeFile("writing file to read/write remote should succeed", remote1, share11, file111, "hello world", true)
+
+	client := &http.Client{
+		Transport: &http.Transport{DisableKeepAlives: true},
+	}
+
+	u := fmt.Sprintf("http://%s/%s/%s/%s/%s",
+		s.local.l.Addr(),
+		url.PathEscape(domain),
+		url.PathEscape(remote1),
+		url.PathEscape(share11),
+		url.PathEscape(file111))
+
+	for _, method := range []string{"LOCK", "UNLOCK"} {
+		req, err := http.NewRequest(method, u, strings.NewReader(lockBody))
+		if err != nil {
+			t.Fatal(err)
+		}
+		resp, err := client.Do(req)
+		if err != nil {
+			t.Fatal(err)
+		}
+		defer resp.Body.Close()
+		if resp.StatusCode != http.StatusMethodNotAllowed {
+			t.Fatalf("expected %s to fail with 405, but got status %d", method, resp.StatusCode)
+		}
+	}
+}
+
 type local struct {
 	l  net.Listener
 	fs *FileSystemForLocal