Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/deephash: fix test regression on 32-bit #12544

Merged
merged 1 commit into from
Jun 19, 2024
Merged

util/deephash: fix test regression on 32-bit #12544

merged 1 commit into from
Jun 19, 2024

Conversation

bradfitz
Copy link
Member

Fix regression from bd93c30 where I didn't notice the 32-bit test failure was real and not its usual slowness-related regression. Yay failure blindness.

Updates #12526

Fix regression from bd93c30 where I didn't notice the
32-bit test failure was real and not its usual slowness-related
regression. Yay failure blindness.

Updates #12526

Change-Id: I00e33bba697e2cdb61a0d76a71b62406f6c2eeb9
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
@bradfitz bradfitz requested a review from agottardo June 19, 2024 19:19
@bradfitz bradfitz marked this pull request as ready for review June 19, 2024 19:20
Copy link
Contributor

@agottardo agottardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what I'm reviewing but it looks good to me.

@bradfitz bradfitz merged commit 1023b2a into main Jun 19, 2024
46 checks passed
@bradfitz bradfitz deleted the bradfitz/deep32 branch June 19, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants