controlclient: handle nil Logf option

[crawshaw]

No description provided.

[apenwarr]

Why are we allowing a nil logf? That doesn't seem like a good idea.

[crawshaw]

This was a quick fix of a panic in one of my test binaries. Arguably it should print to stderr with a big warning.

…

On Tue, Feb 11 2020 at 3:21 PM, apenwarr < ***@***.*** > wrote: ***@***.**** commented on this pull request. Why are we allowing a nil logf? That doesn't seem like a good idea. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub ( #33?email_source=notifications&email_token=AABHMJ6446DBNUGK7OPJGL3RCMCFXA5CNFSM4KTH2GZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCVDOAUI#pullrequestreview-356966481 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AABHMJ4POXRFAONMPTGNY2DRCMCFXANCNFSM4KTH2GZA ).

[apenwarr]

Isn't a panic exactly right? It should abort the program because the program is fundamentally broken. On Tue, Feb 11, 2020 at 3:26 PM David Crawshaw <notifications@github.com> wrote:

…

This was a quick fix of a panic in one of my test binaries. Arguably it should print to stderr with a big warning. On Tue, Feb 11 2020 at 3:21 PM, apenwarr < ***@***.*** > wrote: > > > > ***@***.**** commented on this pull request. > > > > Why are we allowing a nil logf? That doesn't seem like a good idea. > > > > — > You are receiving this because you modified the open/close state. > Reply to this email directly, view it on GitHub ( > #33?email_source=notifications&email_token=AABHMJ6446DBNUGK7OPJGL3RCMCFXA5CNFSM4KTH2GZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCVDOAUI#pullrequestreview-356966481 > ) , or unsubscribe ( > https://github.com/notifications/unsubscribe-auth/AABHMJ4POXRFAONMPTGNY2DRCMCFXANCNFSM4KTH2GZA > ). > > > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#33?email_source=notifications&email_token=AAAFA4FFERJU4ZMT6KJCUSTRCMCVTA5CNFSM4KTH2GZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELN53SA#issuecomment-584834504>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAFA4FI7QYFMDFU5O4JVC3RCMCVTANCNFSM4KTH2GZA> .