ipn: move Options.ServerURL into Prefs. #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danderson
force-pushed
the
danderson/server-url
branch
2 times, most recently
from
480efc0
to
7683323
Compare
We can't rely on a frontend to provide a control server URL, so this naturally belongs in server-persisted state. Signed-off-by: David Anderson <dave@natulte.net>
danderson
force-pushed
the
danderson/server-url
branch
from
7683323
to
c53b74e
Compare
crawshaw
approved these changes
Feb 19, 2020
There was a problem hiding this comment.
Aside: I was thinking we might soon have to add another URL for v2 of the protocol, but it occurs to me that in our last meeting we agreed to start over http2, which we are already talking to login.tailscale.com. So we can implement it by adding handlers on this one connection.
|
In general, I feel a bit unsafe about our current handling of client-side state - specifically, introducing new values that need some value for ipn to be usable. I bolted that into prefs.go for this change, but I don't think it's a sustainably maintainable thing if we do this often. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't rely on a frontend to provide a control
server URL for tailscaled, so this naturally belongs
in server-persisted state.
Signed-off-by: David Anderson dave@natulte.net