Bubble Escape event even if Combobox.Options is not rendered at all
#1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you use `<Combobox.Options static />` it means that you are in
control of rendering and in that case we also bubble the `Escape`
because you are in control of it.
However, if you do something like this:
```js
{filteredList.length > 0 && (
<Combobox.Options static>
...
</Combobox.Options>
)}
```
Then whenever the `filteredList` is empty, the Combobox.Options are not
rendered at all which means that we can't look at the `static` prop. To
fix this, we also bubble the `Escape` event if we don't have a
`Combobox.Options` at all so that the above example works as expected.
|
This pull request is being automatically deployed with Vercel (learn more). headlessui-react – ./packages/playground-react🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-react/4VAzsPQh6mTiLdsyfecjoHtNruw5 headlessui-vue – ./packages/playground-vue🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-vue/J6LKy6SFMDHWqrWJcVbVDR22dcv5 |
RobinMalfait
force-pushed
the
bubble-escape-without-combobox-options
branch
from
f02ed1e
to
16e4a5c
Compare
RobinMalfait
force-pushed
the
bubble-escape-without-combobox-options
branch
from
16e4a5c
to
440ff29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use
<Combobox.Options static />it means that you are incontrol of rendering and in that case we also bubble the
Escapebecause you are in control of it.
However, if you do something like this:
Then whenever the
filteredListis empty, the Combobox.Options are notrendered at all which means that we can't look at the
staticprop. Tofix this, we also bubble the
Escapeevent if we don't have aCombobox.Optionsat all so that the above example works as expected.