Adjust active {item,option} index #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). headlessui-react – ./packages/playground-react🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-react/3GWQ8M5hSGbCuaKYCCVayzLNW7Nb headlessui-vue – ./packages/playground-vue🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-vue/32AtnpUMwhVw9HS1e5Hp2kFmgt8e |
RobinMalfait
force-pushed
the
adjust-active-option-index
branch
from
330294e
to
2275d50
Compare
We had various ordering issues, and now we properly sort all the notes which is awesome. However, there is this case where we still use the `activeOptionIndex` / `activeItemIndex` from _before_ the sort happens. Now we will ensure that this is properly adjusted when performing the sort of the items. In addition, we will also properly adjust these values when `registering` and `unregistering` items, not only when performing actions.
RobinMalfait
force-pushed
the
adjust-active-option-index
branch
from
2275d50
to
96e65e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had various ordering issues, and now we properly sort all the nodes which is awesome. However, there is this case where we still use the
activeOptionIndex/activeItemIndexfrom before the sort happens.Now we will ensure that this is properly adjusted when performing the sort of the items.
In addition, we will also properly adjust these values when
registeringandunregisteringitems, not only when performing actions.Fixes: #1170