Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust active {item,option} index #1184

Merged
merged 2 commits into from Mar 2, 2022
Merged

Adjust active {item,option} index #1184

merged 2 commits into from Mar 2, 2022

Commits on Mar 2, 2022

  1. adjust active {item,option} index 

    We had various ordering issues, and now we properly sort all the notes
which is awesome. However, there is this case where we still use the
`activeOptionIndex` / `activeItemIndex` from _before_ the sort happens.

Now we will ensure that this is properly adjusted when performing the
sort of the items.

In addition, we will also properly adjust these values when
`registering` and `unregistering` items, not only when performing
actions.
    @RobinMalfait
    RobinMalfait committed Mar 2, 2022
    Copy the full SHA
    2937196 View commit details
    Browse the repository at this point in the history

  2. update changelog

    @RobinMalfait
    RobinMalfait committed Mar 2, 2022
    Copy the full SHA
    96e65e4 View commit details
    Browse the repository at this point in the history