Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly merge incoming props with own props #1651

Merged
merged 7 commits into from
Jul 7, 2022
Merged

Conversation

RobinMalfait
Copy link
Member

This PR will apply the same logic as we did in the React version where incoming props should be
merged with our own props.

  • If we internally provide an onClick, then it should first call the onClick of the incoming prop then our own onClick.
  • If the incoming onClick runs event.preventDefault() then the rest of the onClick listeners (e.g.: our internal onClick) will not be fired.

Fixes #1579

@vercel
Copy link

vercel bot commented Jul 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
headlessui-react ✅ Ready (Inspect) Visit Preview Jul 7, 2022 at 2:47PM (UTC)
headlessui-vue ✅ Ready (Inspect) Visit Preview Jul 7, 2022 at 2:47PM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Vue] Clicking on PopoverButton inside PopoverPanel doesn't trigger @click handler, only closes popover
1 participant