Properly merge incoming props with own props #1651
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will apply the same logic as we did in the React version where incoming props should be
merged with our own props.
onClick
, then it should first call theonClick
of the incoming prop then our ownonClick
.onClick
runsevent.preventDefault()
then the rest of theonClick
listeners (e.g.: our internalonClick
) will not be fired.Fixes #1579