Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seanaye/feat/deno ssr #1671

Merged
merged 6 commits into from
Jul 14, 2022
Merged

Conversation

seanaye
Copy link
Contributor

@seanaye seanaye commented Jul 13, 2022

PR adds compat for SSR in Deno

window is defined in Deno so checking that is inusfficient
This PR adds checks for document in addition to window

  • check typeof document in addition to typeof window
  • remove unused import

@vercel
Copy link

vercel bot commented Jul 13, 2022

@seanaye is attempting to deploy a commit to the Tailwind Labs Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jul 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
headlessui-react ✅ Ready (Inspect) Visit Preview Jul 14, 2022 at 4:10PM (UTC)
headlessui-vue ✅ Ready (Inspect) Visit Preview Jul 14, 2022 at 4:10PM (UTC)

@thecrypticace
Copy link
Contributor

CI seems like it's just not running gonna close and reopen to see if that fixes it…

@thecrypticace
Copy link
Contributor

Thanks for the PR! 🎉

This will be in our insiders build soon if you want to test it before our next release:

Vue: npm install @headlessui/vue@insiders
React: npm install @headlessui/react@insiders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants