Don't assume <Tab /> components are available when setting the next index
#2642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we were assuming that the `tabs` were always there, but this
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we assume that the
Tabcomponents are rendered when calculating the active index. But this isn't always the case if we are lazy loading the tab components.If no tabs are available, then calculating the next index would result in
-1which is incorrect because then nothing is selected. Instead, we keep the currently selected index (typically0) and once thetabgets loaded it will be the active one automatically.Fixes: #2596
Fixes: #2640