Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Combobox activeOption render prop #2973

Merged
merged 2 commits into from Feb 7, 2024

Conversation

reinink
Copy link
Member

@reinink reinink commented Feb 7, 2024

Fixes #2963
Fixes #2964

This PR fixes an issue with the Combobox component's activeOption render prop which was always null and also causing an error when hovering over an option with a null value.

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headlessui-react 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 8:25pm
headlessui-vue ❌ Failed (Inspect) Feb 7, 2024 8:25pm

@reinink reinink merged commit a3ca52e into 1.x Feb 7, 2024
6 of 8 checks passed
@reinink reinink deleted the fix-combobox-active-option-render-prop branch February 7, 2024 20:29
reinink added a commit that referenced this pull request Feb 7, 2024
* Fix Combobox `activeOption` render prop

* Update changelog
@reinink reinink self-assigned this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant