Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Combobox activeOption render prop #2973

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Fix Combobox activeOption render prop #2973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5ebed1
Fix Combobox `activeOption` render prop
reinink Feb 7, 2024
4408376
Update changelog
reinink Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@headlessui-vue/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

- Nothing yet!
- Fix Combobox `activeOption` render prop ([#2973](https://github.com/tailwindlabs/headlessui/pull/2973))

## [1.7.18] - 2024-02-02

Expand Down
2 changes: 1 addition & 1 deletion packages/@headlessui-vue/src/components/combobox/combobox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,7 +725,7 @@ export let Combobox = defineComponent({
? null
: api.virtual.value
? api.virtual.value.options[api.activeOptionIndex.value ?? 0]
: api.options.value[api.activeOptionIndex.value]?.dataRef.value.value ?? null,
: api.options.value[api.activeOptionIndex.value]?.dataRef.value ?? null,
value: value.value,
}

Expand Down