Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t cancel touchmove on input elements inside a dialog #3166

Merged
merged 3 commits into from
May 3, 2024

Conversation

thecrypticace
Copy link
Contributor

We prevent the default touchmove event on some elements inside a dialog on iOS as it is the only reliable way to prevent scrolling as overflow: hidden itself is not enough in some cases.

We shouldn't do this for input elements because cancelling the event for <input type="range"> prevents the user from interacting with it at all. This PR checks for input elements and bails.

Fixes #3165

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headlessui-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 2:31pm
headlessui-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 2:31pm

@ErikBooij
Copy link

This is the most impressive response time, I've ever seen to my issue reports. Big kudos, much appreciated, can't wait for this to land 🙏 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Range input (slider) broken in Dialog on iOS
3 participants