Skip to content

Commit

Permalink
Merge pull request #363 from tailwindcss/fix-362
Browse files Browse the repository at this point in the history
Undo border-style reset Normalize applies to images
  • Loading branch information
adamwathan committed Jan 25, 2018
2 parents f87c930 + 6493bda commit cd2f855
Showing 1 changed file with 28 additions and 0 deletions.
28 changes: 28 additions & 0 deletions css/preflight.css
Expand Up @@ -527,6 +527,21 @@ ul {
* Tailwind custom reset styles
*/

/**
* Allow adding a border to an element by just adding a border-width.
*
* By default, the way the browser specifies that an element should have no
* border is by setting it's border-style to `none` in the user-agent
* stylesheet.
*
* In order to easily add borders to elements by just setting the `border-width`
* property, we change the default border-style for all elements to `solid`, and
* use border-width to hide them instead. This way our `border` utilities only
* need to set the `border-width` property instead of the entire `border`
* shorthand, making our border utilities much more straightforward to compose.
*
* https://github.com/tailwindcss/tailwindcss/pull/116
*/
*,
*::before,
*::after {
Expand All @@ -535,6 +550,19 @@ ul {
border-color: config('borderColors.default', currentColor);
}

/**
* Undo the `border-style: none` reset that Normalize applies to images so that
* our `border-{width}` utilities have the expected effect.
*
* The Normalize reset is unnecessary for us since we default the border-width
* to 0 on all elements.
*
* https://github.com/tailwindcss/tailwindcss/issues/362
*/
img {
border-style: solid;
}

/**
* Temporary reset for a change introduced in Chrome 62 but now reverted.
*
Expand Down

0 comments on commit cd2f855

Please sign in to comment.