Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] line-clamp overflow typo bug #13217

Closed
hmbanan666 opened this issue Mar 12, 2024 · 2 comments
Closed

[v4] line-clamp overflow typo bug #13217

hmbanan666 opened this issue Mar 12, 2024 · 2 comments

Comments

@hmbanan666
Copy link
Contributor

What version of Tailwind CSS are you using?

4.0.0-alpha.8

What build tool (or framework if it abstracts the build tool) are you using?

next 14.1.3, @tailwindcss/postcss 4.0.0-alpha.8

What version of Node.js are you using?

v20.11.1

What browser are you using?

Arc

What operating system are you using?

macOS

Describe your issue

line-clamp on output is broken:

.line-clamp-1 {
    overlow: hidden; /* Problem */
    display: -webkit-box;
    -webkit-box-orient: vertical;
    -webkit-line-clamp: 1;
  }
  .line-clamp-2 {
    overlow: hidden;
    display: -webkit-box;
    -webkit-box-orient: vertical;
    -webkit-line-clamp: 2;
  }
  .line-clamp-5 {
    overlow: hidden;
    display: -webkit-box;
    -webkit-box-orient: vertical;
    -webkit-line-clamp: 5;
  }

Some fix needed on "overflow: hidden;", not "overlow: hidden;"

Thanks! v4 is awesome!

@hmbanan666 hmbanan666 changed the title line-clamp overflow typo bug [v4] line-clamp overflow typo bug Mar 12, 2024
@hmbanan666
Copy link
Contributor Author

Found this problem in:

packages/tailwindcss/src/utilities.ts on lines 789, 798
packages/tailwindcss/src/utilities.test.ts on lines 1328, 1335, 1342, 1349

RobinMalfait added a commit that referenced this issue Mar 12, 2024
* Overflow fix for #13217

* webkit-box-orient and webkit-line-clamp fix for #13217

* tests fix #13217

* update changelog

---------

Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
@RobinMalfait
Copy link
Contributor

Hey!

Thanks for the bug report. We've merged your PR (#13220) and will get a release out soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants