-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make dependencies of config watchable #1072
Make dependencies of config watchable #1072
Conversation
Looks like you solve the problem debated in this live session ! Please merge @adamwathan 🙏 |
@adamwathan , how can I help with continuing this staff? |
Sorry just haven't had a chance to play with this yet! One thing I noticed looking briefly but unsure if is true, does this recursively watch dependencies? Say I have a file like this: const plugins = require('./plugins')
module.exports = {
// ...
plugins: plugins
} And inside plugins I have this: // plugins.js
module.exports = [
require('./buttons'),
require('./form-controls'),
require('./animations'),
] Would the |
Yes, this recursively watches dependencies |
Awesome, tested it out and works great 👍 Thank you! |
@serh11p @adamwathan This doesn't appear to be working if the required file is from an NPM package. Any ideas? |
That’s by design, watching the entire tree of dependencies through to node_modules makes things really, really, slow, and it’s sort of out of the ordinary to be editing files directly in node_modules. What’s your use case? |
@adamwathan Yeah, you're right... currently I'm developing a design system and separate app that consumes that design system in tandem so I'm importing the Tailwind config from the design system package ( |
#488