Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull pseudo elements outside of :is and :has when using @apply #10903

Merged
merged 7 commits into from
Mar 29, 2023

Conversation

thecrypticace
Copy link
Contributor

@thecrypticace thecrypticace commented Mar 29, 2023

In previous versions of Tailwind we'd pull pseudo elements like ::before and ::after to the end of the selector. This behavior changed with the introduction of :is in variants like dark, rtl, etc…

Now we'll move pseudo elements outside of :is and :has because they're not valid inside them. In addition for pseudo elements like ::file-selector-button which accept :hover or other user-action pseudo classes we will move them as a group outside of :is or :has.

Fixes #10899

@reinink reinink closed this Mar 29, 2023
@reinink reinink reopened this Mar 29, 2023
@reinink reinink force-pushed the fix/apply-is-and-has-pseudos branch from 32c1a9e to 0d5f2df Compare March 29, 2023 18:37
@RobinMalfait RobinMalfait changed the base branch from 3.3 to master March 29, 2023 19:21
@RobinMalfait RobinMalfait changed the base branch from master to 3.3 March 29, 2023 19:22
@RobinMalfait RobinMalfait merged commit 0ecc464 into 3.3 Mar 29, 2023
@RobinMalfait RobinMalfait deleted the fix/apply-is-and-has-pseudos branch March 29, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

after update from 3.2.7 to 3.3.0 pseudo elements after and before doesn't get dark: ... anymore
3 participants